Fix: make all option properties optional #106
Conversation
| @@ -5,31 +5,31 @@ export type CollectionConfig = { | |||
| /** | |||
| * - One or more glob patterns to match files to a collection | |||
| */ | |||
| pattern: string | string[]; | |||
| pattern?: string | string[] | null; | |||
There was a problem hiding this comment.
The nulls are because the default options use them:
Line 38 in 362c20c
| @@ -5,31 +5,31 @@ export type CollectionConfig = { | |||
| /** | |||
| * - One or more glob patterns to match files to a collection | |||
| */ | |||
| pattern: string | string[]; | |||
| pattern?: string | string[] | null; | |||
There was a problem hiding this comment.
The root change I want to correct is the ability for pattern to be omitted, such that the collection frontmatter array is used.
Proof it's optional:
Line 129 in 362c20c
I think the rest of the properties are optional as well, as I see them all given defaults.
There was a problem hiding this comment.
Ah yeah good catch. I need to check if having the null makes sense. Also, currently developing new major and had to make quite some breaking changes: main...release/2.x.
Still need to wrap my head around some things, like how to make "next" and "previous" references work and how to access "all" vs "own" collections from the metadata
Attempting to fix some TypeScript typing such that option properties are optional.