Implement Iterator#partition() to partition it into arrays #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belochub
reviewed
Jul 2, 2020
belochub
reviewed
Jul 2, 2020
lib/iterator.js
Outdated
| // value <any> current iterator element. | ||
| // Returns: <boolean> | <number> key denoting resulting partition this | ||
| // value will be assigned to. Number denotes index in the resulting | ||
| // array. Boolean will be mapped `false` -> `0`, `true` -> `1`. |
There was a problem hiding this comment.
Suggested change
| // array. Boolean will be mapped `false` -> `0`, `true` -> `1`. | |
| // array. Boolean will be cast to number. |
lib/iterator.js
Outdated
Comment on lines
200
to
202
| let index; | ||
| if (typeof res !== 'number') index = res ? 1 : 0; | ||
| else index = res; |
There was a problem hiding this comment.
Suggested change
| let index; | |
| if (typeof res !== 'number') index = res ? 1 : 0; | |
| else index = res; | |
| const index = typeof res === 'boolean' ? Number(res) : res; |
belochub
reviewed
Jul 3, 2020
lib/iterator.js
Outdated
| @@ -183,6 +183,33 @@ class Iterator { | |||
| return new SkipWhileIterator(this, predicate, thisArg); | |||
| } | |||
|
|
|||
| // Consumes an iterator, partitioning it into Arrays. | |||
There was a problem hiding this comment.
Same as for the previous PR, remove the dots
Suggested change
| // Consumes an iterator, partitioning it into Arrays. | |
| // Consumes an iterator, partitioning it into Arrays |
lundibundi
force-pushed
the
impl-iter-partition
branch
from
4ca0ac4
to
083b92d
Compare
lundibundi
force-pushed
the
impl-iter-partition
branch
from
083b92d
to
1f9b7ff
Compare
nechaido
approved these changes
Jul 5, 2020
4 tasks
belochub
approved these changes
Jul 6, 2020
belochub
pushed a commit
that referenced
this pull request
Jul 6, 2020
|
Landed in 58456fa. |
lundibundi
added a commit
to metarhia/iterator
that referenced
this pull request
Sep 13, 2020
lundibundi
added a commit
to metarhia/iterator
that referenced
this pull request
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run fmt)npm run docto regenerate documentation based on comments)Unreleasedheader in CHANGELOG.md