Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser fails with segfault upon parsing incorrect array #142

Closed
lundibundi opened this issue May 7, 2017 · 0 comments
Closed

Parser fails with segfault upon parsing incorrect array #142

lundibundi opened this issue May 7, 2017 · 0 comments
Assignees
@belochub
Labels
bug parser

Comments

@lundibundi
Copy link
Member

With the following command parse("['whatever]") parser fails with segfault. Tested on master and 0.6.
@belochub belochub self-assigned this May 7, 2017
belochub added a commit that referenced this issue May 7, 2017
@belochub
parser: fix exceptions being ignored
388bbfb 
* Avoid continuing execution after exception is thrown
  inside a parsing method call.
* Return undefined when possible in cases of exceptions
  raising in all of the methods (to reduce memory usage).

Fixes: #142
@belochub belochub mentioned this issue May 7, 2017
Closed
@aqrln aqrln closed this as completed in 29b3e19 May 8, 2017
belochub added a commit that referenced this issue Jan 22, 2018
@belochub
parser: fix exceptions being ignored
2a40f2c 
* Avoid continuing execution after exception is thrown
  inside a parsing method call.
* Return undefined when possible in cases of exceptions
  raising in all of the methods (to reduce memory usage).

PR-URL: #143
Fixes: #142
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub added a commit that referenced this issue Jan 22, 2018
@belochub
parser: fix exceptions being ignored
a01a4bc 
* Avoid continuing execution after exception is thrown
  inside a parsing method call.
* Return undefined when possible in cases of exceptions
  raising in all of the methods (to reduce memory usage).

PR-URL: #143
Fixes: #142
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub added a commit to metarhia/mdsf that referenced this issue Jul 19, 2018
@belochub @aqrln
parser: fix exceptions being ignored
2f8434a 
* Avoid continuing execution after exception is thrown
  inside a parsing method call.
* Return undefined when possible in cases of exceptions
  raising in all of the methods (to reduce memory usage).

PR-URL: metarhia/jstp#143
Fixes: metarhia/jstp#142
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub added a commit to metarhia/mdsf that referenced this issue Jul 19, 2018
@belochub @aqrln
parser: fix exceptions being ignored
692fe93 
* Avoid continuing execution after exception is thrown
  inside a parsing method call.
* Return undefined when possible in cases of exceptions
  raising in all of the methods (to reduce memory usage).

PR-URL: metarhia/jstp#143
Fixes: metarhia/jstp#142
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
belochub added a commit to metarhia/mdsf that referenced this issue Jul 21, 2018
@belochub
parser: fix exceptions being ignored
98d49f1 
* Avoid continuing execution after exception is thrown
  inside a parsing method call.
* Return undefined when possible in cases of exceptions
  raising in all of the methods (to reduce memory usage).

PR-URL: metarhia/jstp#143
Fixes: metarhia/jstp#142
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belochub belochub

Labels
bug parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@belochub @lundibundi