transports: convert to Duplex streams [WIP] #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
changed the title
aqrln
changed the title
|
@belochub it is okay to push your commits to this branch too, btw, if you wanna help. |
aqrln
force-pushed
the
transport-stream
branch
5 times, most recently
from
fb381d2
to
5f92e0b
Compare
|
Closing for now as the status of this change and whether we need this is unclear. I'll rebase the branch and reopen the PR later if we actually do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work-in progress PR to keep track of work on converting JSTP transports to streams.
This is required (well, required is too strong a word for it, it's rather highly desirable in order to do it the right way) to implement #33 and buffering for sessions (#81 and #85), and indeed necessary to resolve some resource consumption issues we encountered in load tests.
@belochub, @tshemsedinov, I'd be happy to have this reviewed as it goes, not only when it's ready, so feel free to leave your comments anytime to any commit, even though it's a work-in-progress PR.