From c4aba23194a89ec359ebe1b0592b34c6c14f4def Mon Sep 17 00:00:00 2001
From: Alexey Orlenko <eaglexrlnk@gmail.com>
Date: Sun, 26 Feb 2017 23:05:34 +0200
Subject: [PATCH] lib: make failed addon loading more informative

* Make `common.safeRequire` print the reason of failed require() to
  stderr. The error wasn't passed anywhere so the reason was lost
  and could not be delivered to user. When the Record Serialization
  parser could not load its native addon, it always stated that it
  isn't built though the actual reason might be different.

* Fix somewhat misleading language in the error message in
  `lib/record-serialization.js`. The addon is not only used on server.

For example, when the addon was compiled with a wrong version of
`node-gyp`, JSTP used to print:

> JSTP native addon is not built. Run `npm install` in order to build
> it, otherwise you will get poor server performance under load.

and it continued to print the same message however many times `npm
install` was invoked, which is certainly not very helpful.

Now the error message in the same situation looks like this:

> Error: The module
> '/Users/alex/projects/metarhia/JSTP/build/Release/jstp.node'
> was compiled against a different Node.js version using
> NODE_MODULE_VERSION 51. This version of Node.js requires
> NODE_MODULE_VERSION 53. Please try re-compiling or re-installing
> the module (for instance, using `npm rebuild` or `npm install`).
> Error: Cannot find module '../build/Debug/jstp'
> JSTP native addon is not built or is not functional. Run `npm install`
> in order to build it, otherwise you will get poor performance.

and is certainly more helpful since it contains an obvious reference to
ABI incompatibility and makes it possible to troubleshoot it.

PR-URL: https://github.com/metarhia/JSTP/pull/90
---
 lib/common.js               | 1 +
 lib/record-serialization.js | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/common.js b/lib/common.js
index 7ad4496..8aa246d 100644
--- a/lib/common.js
+++ b/lib/common.js
@@ -33,6 +33,7 @@ common.safeRequire = (moduleName) => {
   try {
     return require(moduleName);
   } catch (err) {
+    console.warn(err.toString());
     return null;
   }
 };
diff --git a/lib/record-serialization.js b/lib/record-serialization.js
index 3bc2133..37ebffc 100644
--- a/lib/record-serialization.js
+++ b/lib/record-serialization.js
@@ -23,9 +23,9 @@ if (jstpNative) {
   }
 } else {
   console.warn(
-    'JSTP native addon is not built. ' +
+    'JSTP native addon is not built or is not functional. ' +
     'Run `npm install` in order to build it, otherwise you will get ' +
-    'poor server performance under load.'
+    'poor performance.'
   );
   module.exports = require('./record-serialization-fallback');
 }