Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication in rpc and hook #493

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Code duplication in rpc and hook #493

wants to merge 4 commits into from

Conversation

axbuglak
Copy link

@axbuglak axbuglak commented Feb 19, 2024 •
edited
Loading

RP for #490

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

axbuglak
axbuglak commented Feb 21, 2024
View reviewed changes
lib/server.js Outdated Show resolved Hide resolved
@axbuglak
Copy link
Author

axbuglak commented Feb 26, 2024 •
edited
Loading

As discussed in the meeting I made 2 commits. First is for using universal error handling for hook and RPC methods and second(last) one is for reusing of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axbuglak