Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #1387

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Fix warnings #1387

merged 4 commits into from
Nov 11, 2024

Conversation

magnusuMET
Copy link
Collaborator

@magnusuMET magnusuMET commented Oct 28, 2024

Change Summary

Enables warnings as errors, and fixes the warnings emitted during running of the tests.

Iris warning is still ignored, as the fix is not trivial. The relevant path is found in this part of the iris code, we could fix this by using a GeogCS coordinate system.

Related issue number

#1066

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (c322808) to head (c8b2b28).
Report is 38 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1387      +/-   ##
============================================
+ Coverage     78.54%   78.56%   +0.01%     
============================================
  Files           137      137              
  Lines         20895    20905      +10     
============================================
+ Hits          16413    16424      +11     
+ Misses         4482     4481       -1     
Flag Coverage Δ
unittests 78.56% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magnusuMET
Copy link
Collaborator Author

New contributors can't choose their reviewer. Maybe add a "ping @lewisblake if new to the project" should be added to the checklist?

@magnusuMET magnusuMET force-pushed the bugfix/test_fixes branch 2 times, most recently from 8f1f9f6 to d244d85 Compare November 6, 2024 14:09
@lewisblake lewisblake self-requested a review November 11, 2024 10:21
@magnusuMET magnusuMET merged commit b4ea6d7 into metno:main-dev Nov 11, 2024
8 checks passed
@magnusuMET magnusuMET deleted the bugfix/test_fixes branch November 11, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants