-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic ModelEntry #1391
Pydantic ModelEntry #1391
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1391 +/- ##
============================================
+ Coverage 78.50% 78.54% +0.04%
============================================
Files 136 137 +1
Lines 20860 20895 +35
============================================
+ Hits 16377 16413 +36
+ Misses 4483 4482 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
Change Summary
Implements
ModelEntry
in terms of pydantic. Removes classesDictStrKeysListVals
andDictType
from_lowlevel_helpers.py
in pyaerocom. There were a few attributes which, while not declared inModelEntry
, where given askwargs
and were critical to the functionality of the class in downstream processing. These have been added as attributes toModelEntry
. You may notice that many of these attributes are also given as attributes inColocationSetup
. This is because the current functionality copies these attributes from the instance ofModelEntry
and assigns them to the corresponding attribute inColocationSetup
which is specific to a (obs, model) tuple inHasColocator.get_colocator()
. This should be redesigned in the future to minimize confusion.Related issue number
Part of #1085
Needed for work in CAMS2_82 to clean up reading of colocated data sets created by project partners
Checklist