Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow list of strings and Path like objects in PyaroConfig #1400

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Nov 11, 2024

Change Summary

allow [str, list[str], Path, list[Path]] as filename_or_obj_or_url in PyaroConfig

Related issue number

fix #1399

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller self-assigned this Nov 11, 2024
@jgriesfeller jgriesfeller linked an issue Nov 11, 2024 that may be closed by this pull request
@jgriesfeller jgriesfeller added the enhancement ✨ New feature or request label Nov 11, 2024
@jgriesfeller jgriesfeller added this to the m2024-12 milestone Nov 11, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you want is:
filename_or_obj_or_url: str | list[str] | Path | list[Path]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (c8b2b28) to head (b5422c0).
Report is 11 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1400   +/-   ##
=========================================
  Coverage     78.56%   78.56%           
=========================================
  Files           137      137           
  Lines         20905    20905           
=========================================
  Hits          16424    16424           
  Misses         4481     4481           
Flag Coverage Δ
unittests 78.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller marked this pull request as ready for review November 11, 2024 13:57
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@lewisblake lewisblake merged commit 326ef31 into main-dev Nov 12, 2024
8 checks passed
@lewisblake lewisblake deleted the 1399-pyaroconfig-from-pyaerocomiopyaropyaro_config-is-too-pedantic branch November 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyaroConfig from pyaerocom.io.pyaro.pyaro_config is too pedantic
2 participants