-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow list of strings and Path like objects in PyaroConfig #1400
allow list of strings and Path like objects in PyaroConfig #1400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you want is:
filename_or_obj_or_url: str | list[str] | Path | list[Path]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1400 +/- ##
=========================================
Coverage 78.56% 78.56%
=========================================
Files 137 137
Lines 20905 20905
=========================================
Hits 16424 16424
Misses 4481 4481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄
Change Summary
allow
[str, list[str], Path, list[Path]]
asfilename_or_obj_or_url
inPyaroConfig
Related issue number
fix #1399
Checklist