Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't prefix output properties check rule #440

Merged
merged 5 commits into from
Oct 29, 2017
Merged

don't prefix output properties check rule #440

merged 5 commits into from
Oct 29, 2017

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Oct 23, 2017

Added a simple rule for checking the name events without the prefix on:

https://angular.io/guide/styleguide#dont-prefix-output-properties

src/index.ts Outdated
@@ -6,13 +6,13 @@ export {Rule as ContextualLifeCycleRule} from './contextualLifeCycleRule';
export {Rule as DecoratorNotAllowedRule} from './decoratorNotAllowedRule';
export {Rule as DirectiveClassSuffixRule} from './directiveClassSuffixRule';
export {Rule as DirectiveSelectorRule} from './directiveSelectorRule';
export {Rule as I18nRule} from './i18nRule';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you export this back?

Copy link
Owner

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment for exporting the i18n rules.

@mgechev mgechev added this to the 4.1.0 - Peter Naur milestone Oct 29, 2017
@eromano
Copy link
Contributor Author

eromano commented Oct 29, 2017

done

@mgechev
Copy link
Owner

mgechev commented Oct 29, 2017

Cool! I'll include it in the 4.0.0 release.

@mgechev mgechev merged commit 8f2b4e7 into mgechev:master Oct 29, 2017
@mgechev mgechev modified the milestones: 4.1.0 - Peter Naur, 4.0.0 - Edsger W. Dijkstra Oct 29, 2017
@eromano
Copy link
Contributor Author

eromano commented Oct 29, 2017

Thanks

mgechev added a commit that referenced this pull request Oct 29, 2017
* 'master' of https://github.com/mgechev/codelyzer:
  don't prefix output properties check rule (#440)
  refactor: drop rules (#448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants