Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for divide into pages to handle when array prototype extensio… #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igorrKurr
Copy link

…ns disabled

@mharris717
Copy link
Owner

Thanks for taking the time to send this in! Will be taking a look shortly.

@mharris717
Copy link
Owner

I assume it would be highly annoying to write a test case for this?

@mharris717
Copy link
Owner

Looks like there are a bunch more changes that need to happen for ember-cli-pagination to work without array prototype extensions. It looks pretty doable tho. If you wanted to take a crack at it, I'd happily take a look when you're done and merge it in, but don't feel any obligation. Let me know, and thanks again for the initial submission!

@mharris717
Copy link
Owner

By "work" in the previous comment, I mean for all the tests to pass.

@mharris717
Copy link
Owner

FYI this is what I put into environment.js to disable only array extensions

'use strict';

module.exports = function(/* environment, appConfig */) {
  return { 
    EmberENV: {
      EXTEND_PROTOTYPES: {
        String: true,
        Array: false,
        Function: true
      }
    } 
  };
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants