Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paged-remote-array.js #143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

noslouch
Copy link

need to return the promises from the paged-remote-array init, otherwise findPaged will not return a promise, which is required in a model hook for Ember's 'wait until promises are resolved' functionality.

need to return the promises from the paged-remote-array init, otherwise `findPaged` will not return a promise, which is required in a `model` hook for Ember's 'wait until promises are resolved' functionality.
@broerse
Copy link
Collaborator

broerse commented Sep 29, 2015

👍

@noslouch
Copy link
Author

noslouch commented Nov 3, 2015

I moved the page-numbers component to the addon namespace and then export it via the addon's app directory so that consumers can extend the component.

@vasilakisfil
Copy link

Yes! I would like to have that! 👍

@noslouch
Copy link
Author

any chance these changes can get merged?

@typeoneerror
Copy link

Returning the result of "get" on the promise here I don't think will have any effect. I mean, it does, but I'm thinking this isn't the best place to set up the promise chain. I just submitted a different PR that returns the promise chain where it is overridding the proxy: https://github.com/mharris717/ember-cli-pagination/pull/173/files#diff-7bfb08d900d77900cce45eec3f9758b3R12. Thoughts?

@broerse
Copy link
Collaborator

broerse commented Feb 16, 2017

@noslouch We had to make some breaking changes to fix the Ember Bindings deprecation. If you change this PR for the current version I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants