Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote processing uses stale indexes if quote contains delimiter or newline #727

Closed
jseter opened this issue Oct 23, 2019 · 0 comments
Closed

Quote processing uses stale indexes if quote contains delimiter or newline #727

jseter opened this issue Oct 23, 2019 · 0 comments

Comments

@jseter
Copy link
Contributor

jseter commented Oct 23, 2019

Referenced in #713 but being separate out into its own bug.
When a quoted field contains newline or the delimiter, the whitespace calculation will use an index for a delimiter that is before the current parsing position instead of after, causing it to evaluate the wrong text for whitespace.
jseter pushed a commit to jseter/PapaParse that referenced this issue Oct 23, 2019
mholt#727 update delimiter and newline index if they are earlier than…
48d1864 
… the current position before tested.
pokoli pushed a commit that referenced this issue Oct 24, 2019
#727 update delimiter and newline index if they are earlier than the …
47b356d 
…current position before tested. (#728)
@pokoli pokoli closed this as completed Oct 24, 2019
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pokoli @jseter