Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to Angular instructions about adding 'skipLibCheck' to tsconfig.json #737

Closed
GCHQ-Developer-847 opened this issue Dec 19, 2023 · 0 comments
Assignees
Labels

Comments

@GCHQ-Developer-847
Copy link
Contributor

What component is this related to?

This ticket involves adding to the Angular getting started instructions.

This relates to the issue mentioned in #736, which is that an Angular app which uses ICDS components will not compile and bring up errors. The solution is to add "skipLibCheck": true to the tsconfig.json file of the app, but it is not mentioned in the Angular instructions on the ICDS website so a step about doing this needs to be added.

Why do we need it?

This will prevent developers who are using ICDS components in Angular apps from encountering related compilation issues.

@GCHQ-Developer-530 GCHQ-Developer-530 self-assigned this Jan 2, 2024
GCHQ-Developer-530 added a commit that referenced this issue Jan 3, 2024
Add skipLibCheck step into angular guidance

. #737
@GCHQ-Developer-530 GCHQ-Developer-530 moved this from Dev In Progress to In Review in Intelligence Community Design System Jan 3, 2024
GCHQ-Developer-530 added a commit that referenced this issue Jan 3, 2024
Add skipLibCheck step into angular guidance

. #737
GCHQ-Developer-530 added a commit that referenced this issue Jan 3, 2024
Add skipLibCheck step into angular guidance

. #737
jd239 pushed a commit that referenced this issue Jan 15, 2024
Add skipLibCheck step into angular guidance

. #737
GCHQ-Developer-299 pushed a commit that referenced this issue Jan 16, 2024
Add skipLibCheck step into angular guidance

. #737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants