Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to ic-side-navigation 'Layout example' #878

Closed
gd2910 opened this issue Mar 22, 2024 · 1 comment
Closed

Change to ic-side-navigation 'Layout example' #878

gd2910 opened this issue Mar 22, 2024 · 1 comment
Assignees
@MI6-94
Labels
dx Related to developers' experience side navigation component The related component page type: bug 🐛 An unexpected problem or unintended behaviour
Milestone
PI 7 V2

Comments

@gd2910
Copy link
Contributor

gd2910 commented Mar 22, 2024

Summary of the bug

The IcSideNavigation layout example needs a style change on the

tag.
Current:
<main style={{height: '100vh'}}>
Change to:
<main style={{minHeight: '100vh'}}>

Base code, web-component and react code snippets will need to be updated.

🪜 How to reproduce

  1. Go to page: 'layout example'
  2. Shrink the window and scroll down
  3. See that the IcTypography is overlapping the footer

🧐 Expected behaviour

Typography should not overlap footer
@gd2910 gd2910 added type: bug 🐛 An unexpected problem or unintended behaviour dx Related to developers' experience side navigation component The related component page labels Mar 22, 2024
@MI6-255
Copy link
Contributor

MI6-255 commented Jun 5, 2024

Instead of fixing it, change this to remove the example and instead redirect to patterns

@MI6-255 MI6-255 added this to the PI 7 V.2 milestone Jun 5, 2024
@MI6-94 MI6-94 self-assigned this Jun 5, 2024
@MI6-94 MI6-94 moved this from In Refinement to Dev In Progress in Intelligence Community Design System Jun 5, 2024
GCHQ-Developer-112 added a commit that referenced this issue Jun 13, 2024
@GCHQ-Developer-112
docs(root): removed legacy layout example and signposted patterns
bc744ec 
. #878 #493
GCHQ-Developer-112 added a commit that referenced this issue Jun 13, 2024
@GCHQ-Developer-112
docs(root): removed legacy layout example and signposted patterns
dd106e4 
. #878 #493
GCHQ-Developer-112 added a commit that referenced this issue Jun 14, 2024
@GCHQ-Developer-112
docs(root): removed legacy layout example and signposted patterns
a3bc6d3 
. #878 #493
@github-project-automation github-project-automation bot moved this from Dev In Progress to Done in Intelligence Community Design System Jun 14, 2024
gd2910 pushed a commit that referenced this issue Jun 27, 2024
@GCHQ-Developer-112 @gd2910
docs(root): removed legacy layout example and signposted patterns
a58fae2 
. #878 #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MI6-94 MI6-94

Labels
dx Related to developers' experience side navigation component The related component page type: bug 🐛 An unexpected problem or unintended behaviour
Projects
Intelligence Community Design System
Archived in project
Milestone
PI 7 V2
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/878-change-to-ic-side-navigation-layout-example mi6/ic-design-system
4 participants
@MI6-94 @MI6-255 @GCHQ-Developer-112 @gd2910