Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ic-loading-indicator | ic-button] Indicator differs from design #2850

Open
gd2910 opened this issue Dec 2, 2024 · 0 comments
Open

[ic-loading-indicator | ic-button] Indicator differs from design #2850

gd2910 opened this issue Dec 2, 2024 · 0 comments
Labels
component: ic-button The generic component, includes both the web component and the React component good first issue A good starter issue if you haven't contributed to the ICDS before loading-indicator component The generic component, includes both the web component and the React component

Comments

@gd2910
Copy link
Contributor

gd2910 commented Dec 2, 2024

Summary

The loading indicator width on ic-button et al is 8px, in Figma this is 4px.

💬 Description

Decide whether design or dev should update the thickness of the indicator

💰 Use value

Keep component inline with design
@gd2910 gd2910 added good first issue A good starter issue if you haven't contributed to the ICDS before component: ic-button The generic component, includes both the web component and the React component loading-indicator component The generic component, includes both the web component and the React component labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ic-button The generic component, includes both the web component and the React component good first issue A good starter issue if you haven't contributed to the ICDS before loading-indicator component The generic component, includes both the web component and the React component
Projects
Intelligence Community Design System
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gd2910