Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for managing loopback devices with Network Manager #163

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

Aethylred
Copy link
Contributor

This addresses Issue #162

Updates the ethernet_nmconnect.j2 template to handle loopback devices, and updates the ether checks to pass them.

It should work for the default lo loopback device, but might need more work to handle other loopback devices if configured.

@Aethylred
Copy link
Contributor Author

I'm not entirely happy with the handler

elif [[ '{{ interface }}' == 'lo' ]]; then

This should really by interface type and not interface name, but I don't know how or if that variable is exposed in the handler playbook

@markgoddard markgoddard merged commit 4ecee7b into michaelrigart:master Jul 16, 2024
@markgoddard
Copy link

Hi @michaelrigart would you be able to import the new v1.15.0 release?

@michaelrigart
Copy link
Owner

@markgoddard, should be available now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants