Help with move plugin changes

[glensc]

I'm maintaining a notification plugin:

• https://github.com/glensc/dokuwiki-plugin-slacknotifier

how to handle page moves more efficiently? as currently each page move sends two events:

• create
• delete

The plugin is listening to COMMON_WIKIPAGE_SAVE event:

$controller->register_hook('COMMON_WIKIPAGE_SAVE', 'AFTER', $this, 'handleSave');

[glensc]

maybe somehow DOKUWIKI_DONE event could help:

• https://www.dokuwiki.org/devel:event:dokuwiki_done

like collect the events to an array, and when DOKUWIKI_DONE is invoked empty that array in memory.

but from my testing, DOKUWIKI_DONE and COMMON_WIKIPAGE_SAVE are fired in different processes, so memory caching will not work. would need to store to filesystem.

[michitux]

One idea could be to use an event that has the before handler called before the move happens and the after handler after the move completed. Your event handler could then ignore or summarize the events (I mean the deletion of the old and creation of the new page) that happen in between the before and after event handler. I'm not sure if such an event already exists, but if not, it could be added.

[glensc]

this is dump of events fired during rename of one page

• events.txt 31K

[michitux]

Are you sure that's from the move plugin and you aren't using another plugin for renaming the page? I'm asking because the move plugin fires an event before and after the move (which you could also use to combine the events as I wrote before): https://github.com/michitux/dokuwiki-plugin-move/blob/master/helper/op.php#L158 - and I cannot see that event in the log.

[glensc]

I renamed via simple rename:

• https://www.dokuwiki.org/plugin:move#simple_page_rename

[glensc]

The native page notification suffers the same problem, sends out two emails:

• page added: organisations: ↷ Page moved from support:organisations to organisations
• page changed: support:organisations ↷ Page moved from support:organisations to organisations

[glensc]

🚧 Never link to branches, share a permalink 🚧

• see https://news.ycombinator.com/item?id=8046710
  and https://help.github.com/articles/getting-permanent-links-to-files/
  and https://docs.gitlab.com/ee/user/shortcuts.html#project-files
• hit y

NOTE: edit your post and fix it with a permalink!

[glensc]

Found that PLUGIN_MOVE_PAGE_RENAME::BEFORE is called, but if an error occurs, there's no knowledge of that to the event listener. so could lose messages.

EDIT: irrelevant: no move actually happens on error.

for I'm running on arm64 with rosetta2 so the indexes is super slow, and rename page gets index locked errors: "Error while updating the search index locked"

[glensc]

Have look:

• Feature: Detect page move events glensc/dokuwiki-plugin-slacknotifier#18

what you think?