Bump extension version when re-training model #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the autogenerated code and extension version in sync
|
Preview build will be at |
| }; | ||
| }; | ||
|
|
||
| export const generateCustomFiles = ( |
There was a problem hiding this comment.
Are there tests for this generation? It feels like it should be pretty straightforward to test the generation (maybe snapshot testing if there's too much output?).
There was a problem hiding this comment.
There aren't at the moment, but yes, should be easy to add.
There was a problem hiding this comment.
I'm going to merge this to help folks move forward with projects that need this version bump, but please can you look at test coverage for project generation next?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the autogenerated code and extension version in sync