Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bump.sh's train travel api #25

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Oct 29, 2024

Description

Adding @bump-sh's Train Travel API as a demo API that folks can use.

@yada
Copy link
Member

yada commented Oct 30, 2024

Thanks, @philsturgeon, for this very excellent contribution.
Please sign the PR to pass the DCO test, which is mandatory ;-)

@philsturgeon
Copy link
Contributor Author

@yada done!

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not the correct URL to final artifact that sticks to Microcks conventions. Could you please check this?

Signed-off-by: Phil Sturgeon <67381+philsturgeon@users.noreply.github.com>
@philsturgeon
Copy link
Contributor Author

@lbroudoux now that bump-sh-examples/train-travel-api#21 is merged pointing to a good Microcks-compatible OpenAPI, and I've fixed the DCO, can you review this again?

@lbroudoux
Copy link
Member

Yep sure!

Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@lbroudoux lbroudoux merged commit 2e9a45c into microcks:master Nov 23, 2024
1 check passed
Copy link

🎉 @philsturgeon

You are now a Microcks community contributor! 💖

Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Kudos and please keep going, we need you 🙌

🌟 ~~~~~~~~~ 🌟

📢 If you like Microcks, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

@lbroudoux
Copy link
Member

Hey @philsturgeon!

The Train API is now available on https://hub.microcks.io! You can check it out directly here: https://hub.microcks.io/package/bump.sh

The Mocks have also been loaded on the https://try.microcks.io instance. You can directly check them there or try a simple call:

curl -X GET 'https://try.microcks.io/rest/Train+Travel+API/1.0.0/bookings' -H 'Accept: application/json'

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants