Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numeric attributes value for tracing attributes #234

Closed
nikoncode opened this issue Apr 18, 2023 · 4 comments
Closed

Support numeric attributes value for tracing attributes #234

nikoncode opened this issue Apr 18, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@nikoncode
Copy link

Current convention support only string valued attributes for observation (future span), but modern tracing backend support numbers in it, which might significantly simplify filtering.

For example, http.status_code (as number) might be used in filter like http.status_code > 200 and http.status_code < 300, but in case of string it's not quite possible.
@marcingrzejszczak marcingrzejszczak added the enhancement New feature or request label Apr 18, 2023
@nikoncode
Copy link
Author

nikoncode commented Apr 18, 2023 •
edited
Loading

Same thing probably for primitives like boolean, long, double

@nikoncode
Copy link
Author

@marcingrzejszczak are you ok if I contribute to make this available at least on span level?

nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 18, 2023
support long, double and boolean for tags micrometer-metrics#234
3decdd8
@marcingrzejszczak
Copy link
Contributor

Yes, I commented on the PR

@marcingrzejszczak marcingrzejszczak added this to the 1.1.0 milestone Apr 19, 2023
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 19, 2023
support long, double and boolean for tags micrometer-metrics#234
a88cd54
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 19, 2023
support long, double and boolean for tags micrometer-metrics#234
bcacb7f
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 19, 2023
support long, double and boolean for tags micrometer-metrics#234
58ce909
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 19, 2023
support long, double and boolean for tags micrometer-metrics#234
6adb7d7
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 19, 2023
support long, double and boolean for tags micrometer-metrics#234
8fc2f0d
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 19, 2023
support long, double and boolean for tags micrometer-metrics#234
0faf66f
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 20, 2023
support long, double and boolean for tags from on Observation layer m…
0ef7236 
…icrometer-metrics#234
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 20, 2023
support long, double and boolean for tags from on Observation layer m…
53c107a 
…icrometer-metrics#234
nikoncode pushed a commit to nikoncode/micrometer-tracing that referenced this issue Apr 20, 2023
support long, double and boolean for tags from on Observation layer m…
eb11083 
…icrometer-metrics#234
@nikoncode nikoncode mentioned this issue Apr 20, 2023
Closed
@marcingrzejszczak
Copy link
Contributor

done via 13f060c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@nikoncode @marcingrzejszczak