From 6647ef56039617d2074b4504d68702925800d846 Mon Sep 17 00:00:00 2001 From: Guillermo Calvo Date: Tue, 22 Aug 2023 14:19:20 +0200 Subject: [PATCH] Use nullable `Boolean` instead of `Optional` --- .../kafka/seek/DefaultKafkaSeeker.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/kafka/src/main/java/io/micronaut/configuration/kafka/seek/DefaultKafkaSeeker.java b/kafka/src/main/java/io/micronaut/configuration/kafka/seek/DefaultKafkaSeeker.java index 193f04884..5566d8471 100644 --- a/kafka/src/main/java/io/micronaut/configuration/kafka/seek/DefaultKafkaSeeker.java +++ b/kafka/src/main/java/io/micronaut/configuration/kafka/seek/DefaultKafkaSeeker.java @@ -57,9 +57,9 @@ public boolean perform(@NonNull KafkaSeekOperation operation) { try { final TopicPartition tp = operation.topicPartition(); if (operation.offset() == 0) { - Optional performed = performForZeroOffset(operation, tp); - if (performed.isPresent()) { - return performed.get(); + Boolean performed = performForZeroOffset(operation, tp); + if (performed != null) { + return performed; } } final long offset = offset(operation, tp); @@ -72,32 +72,32 @@ public boolean perform(@NonNull KafkaSeekOperation operation) { } } - @NonNull - private Optional performForZeroOffset(@NonNull KafkaSeekOperation operation, - @Nullable TopicPartition tp) { + @Nullable + private Boolean performForZeroOffset(@NonNull KafkaSeekOperation operation, + @NonNull TopicPartition tp) { final String topic = operation.topic(); final int partition = operation.partition(); switch (operation.offsetType()) { case FORWARD, BACKWARD -> { // Special case: relative zero-offset LOG.debug("Relative zero-offset seek operation dropped: {}", operation); - return Optional.of(false); + return Boolean.FALSE; } case BEGINNING -> { // Optimized case: seek to the beginning consumer.seekToBeginning(singletonList(tp)); LOG.debug("Seek to the beginning operation succeeded: {}-{}", topic, partition); - return Optional.of(true); + return Boolean.TRUE; } case END -> { // Optimized case: seek to the end consumer.seekToEnd(singletonList(tp)); LOG.debug("Seek to the end operation succeeded: {}-{}", topic, partition); - return Optional.of(true); + return Boolean.TRUE; } default -> { /* Perform operation regularly */ - return Optional.empty(); + return null; } } }