Skip to content

Conversation

@jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Oct 12, 2021

  • changed pod to source form

  • moved c++ and objc++ headers to private

  • Added resource bundle

  • Added excluded files list

This reverts commit 2cd4d4d.

  • updated verison in spec

  • corrected the version

  • tag for ios release

  • Fixed Header files in Unit tests & fixed warnings

Related Issue

A Pull Request should close a single issue; multiple issues can be closed when the issues are small and related, but that should be an exception not the rule. Please keep Pull Requests small and targeted; large 'code drops' with dozens of files will be closed and asked to split into reviewable pieces. Reviews that need to be large due to dependencies will be
reviewed on a case-by-case basis.

Please use one of the well-known github fixes keywords to reference
the issue fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one to aid
in issue tracking.

NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.

Description

For all Pull Requests, please describe how the issue was fixed or how the feature was implemented from a summary level. This information will be used to help provide context to the reviewers of the pull request and should be additive to the issue being closed.

Sample Card

If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit tests that were added if any. If none were added please add a quick line explaining why not.
  2. Existing relevant unit/regression tests that you ran
  3. Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
    will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow

* changed pod to source form

* moved c++ and objc++ headers to private

* Added resource bundle

* Added excluded files list

This reverts commit 2cd4d4d.

* updated verison in spec

* corrected the version

* tag for ios release

* Fixed Header files in Unit tests & fixed warnings
@jwoo-msft jwoo-msft enabled auto-merge (squash) October 12, 2021 23:58
Copy link
Contributor

@jonmill jonmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonmill jonmill disabled auto-merge October 13, 2021 00:35
@jonmill jonmill merged commit 2f52e5c into release/21.09 Oct 13, 2021
@jonmill jonmill deleted the jwoo/ios-release/21.09 branch October 13, 2021 00:35
paulcam206 added a commit that referenced this pull request Apr 27, 2022
* [Infrastructure] Disable failing push job from js-release.yml (#6563)

Disable push job from js-release.yml to be able to continue package release

* [UWP][Infra] Update nuget files for release (#6576)

* Add new nuspec files

* Fix nuspec

* Update build copy script

* Add dependency to renderer

* 1.5 website schema explorer updates (#6550)

* Updating schema explorer properties

* adding tableCell to toc and attempting whitespace fix

* indentation fix

indentation fix

* Removing filtered prop

Removing filtered prop - it's auto generated in our build

Co-authored-by: RahulAmlekar <raamleka@microsoft.com>

* Custom.props to 1.0.0 for Object model build

* Update dependency version

Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>

* Changed pod to source form (#6582) (#6586)

* changed pod to source form

* moved c++ and objc++ headers to private

* Added resource bundle

* Added excluded files list

This reverts commit 2cd4d4d.

* updated verison in spec

* corrected the version

* tag for ios release

* Fixed Header files in Unit tests & fixed warnings

* [Infrastructure][.NET] Update public key location for signing (#6589)

* Update public key name

* Fix name

* Test path

* Test path

* Test path

* Test path

* Test path

* Test path

* Update key to right key

* Updated min supported iOS version  (#6593)

* updated supported min version to iOS 12

* updated podspec

* updated symlinks

* [UWP]: Update ObjectModelProjection.vcxproj to have control flow guard (#6729)

* Update ObjectModelProjection.vcxproj

Add control guard on all flavors of binaries

* Update ObjectModelProjection.vcxproj

* [UWP] Update custom.props version for cfguard patch release

* [UWP]: Don't use AdaptiveImage to render BackgroundImage (#6838)

* increment version

* bring up to master

* update rendering nuspec

* update rendering nuspec

* remove deprecated html renderer

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>
Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Co-authored-by: Nassim Amar <namar0x0309@users.noreply.github.com>
Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* [Infrastructure] Disable failing push job from js-release.yml (microsoft#6563)

Disable push job from js-release.yml to be able to continue package release

* [UWP][Infra] Update nuget files for release (microsoft#6576)

* Add new nuspec files

* Fix nuspec

* Update build copy script

* Add dependency to renderer

* 1.5 website schema explorer updates (microsoft#6550)

* Updating schema explorer properties

* adding tableCell to toc and attempting whitespace fix

* indentation fix

indentation fix

* Removing filtered prop

Removing filtered prop - it's auto generated in our build

Co-authored-by: RahulAmlekar <raamleka@microsoft.com>

* Custom.props to 1.0.0 for Object model build

* Update dependency version

Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>

* Changed pod to source form (microsoft#6582) (microsoft#6586)

* changed pod to source form

* moved c++ and objc++ headers to private

* Added resource bundle

* Added excluded files list

This reverts commit 2cd4d4d.

* updated verison in spec

* corrected the version

* tag for ios release

* Fixed Header files in Unit tests & fixed warnings

* [Infrastructure][.NET] Update public key location for signing (microsoft#6589)

* Update public key name

* Fix name

* Test path

* Test path

* Test path

* Test path

* Test path

* Test path

* Update key to right key

* Updated min supported iOS version  (microsoft#6593)

* updated supported min version to iOS 12

* updated podspec

* updated symlinks

* [UWP]: Update ObjectModelProjection.vcxproj to have control flow guard (microsoft#6729)

* Update ObjectModelProjection.vcxproj

Add control guard on all flavors of binaries

* Update ObjectModelProjection.vcxproj

* [UWP] Update custom.props version for cfguard patch release

* [UWP]: Don't use AdaptiveImage to render BackgroundImage (microsoft#6838)

* increment version

* bring up to master

* update rendering nuspec

* update rendering nuspec

* remove deprecated html renderer

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>
Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Co-authored-by: Nassim Amar <namar0x0309@users.noreply.github.com>
Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* [Infrastructure] Disable failing push job from js-release.yml (microsoft#6563)

Disable push job from js-release.yml to be able to continue package release

* [UWP][Infra] Update nuget files for release (microsoft#6576)

* Add new nuspec files

* Fix nuspec

* Update build copy script

* Add dependency to renderer

* 1.5 website schema explorer updates (microsoft#6550)

* Updating schema explorer properties

* adding tableCell to toc and attempting whitespace fix

* indentation fix

indentation fix

* Removing filtered prop

Removing filtered prop - it's auto generated in our build

Co-authored-by: RahulAmlekar <raamleka@microsoft.com>

* Custom.props to 1.0.0 for Object model build

* Update dependency version

Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>

* Changed pod to source form (microsoft#6582) (microsoft#6586)

* changed pod to source form

* moved c++ and objc++ headers to private

* Added resource bundle

* Added excluded files list

This reverts commit 2cd4d4d.

* updated verison in spec

* corrected the version

* tag for ios release

* Fixed Header files in Unit tests & fixed warnings

* [Infrastructure][.NET] Update public key location for signing (microsoft#6589)

* Update public key name

* Fix name

* Test path

* Test path

* Test path

* Test path

* Test path

* Test path

* Update key to right key

* Updated min supported iOS version  (microsoft#6593)

* updated supported min version to iOS 12

* updated podspec

* updated symlinks

* [UWP]: Update ObjectModelProjection.vcxproj to have control flow guard (microsoft#6729)

* Update ObjectModelProjection.vcxproj

Add control guard on all flavors of binaries

* Update ObjectModelProjection.vcxproj

* [UWP] Update custom.props version for cfguard patch release

* [UWP]: Don't use AdaptiveImage to render BackgroundImage (microsoft#6838)

* increment version

* bring up to master

* update rendering nuspec

* update rendering nuspec

* remove deprecated html renderer

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Rahul Amlekar <rahul.amlekar@mail.mcgill.ca>
Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>
Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Co-authored-by: Nassim Amar <namar0x0309@users.noreply.github.com>
Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants