Skip to content

[iOS] Unit Test Logging Update #6844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwoo-msft merged 6 commits into from
Dec 14, 2021
Merged

[iOS] Unit Test Logging Update #6844

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d340ac6
Updated Unit Test Error messages
jwoo-msft Dec 10, 2021
4d7f19b
added test file -revert this commit in the future
jwoo-msft Dec 10, 2021
a1e86f6
updated logging
jwoo-msft Dec 10, 2021
506aeb1
Revert "added test file -revert this commit in the future"
jwoo-msft Dec 10, 2021
a566637
Merge branch 'main' into jwoo/ios-test-update
jwoo-msft Dec 13, 2021
e80cd70
Merge branch 'main' into jwoo/ios-test-update
jwoo-msft Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerTests/ADCIOSVisualizerTests.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,35 +200,47 @@ - (void)parseAndRenderDFS:(NSString *)rootPath FileManager:(NSFileManager *)fMan
if ([_setOfExpectedToFailFiles containsObject:fileName]) {
XCTAssertFalse(cardParseResult.isValid);
} else {
if (!cardParseResult.isValid) {
NSException *e = [NSException exceptionWithName:@"ParseFailed" reason:@"Parsing Failed" userInfo:nil];
@throw e;
}
XCTAssertTrue(cardParseResult.isValid);
[self assertParsing:cardParseResult fileName:fileName];
ACRRenderResult *renderResult;
@try {
renderResult = [ACRRenderer render:cardParseResult.card
config:nil
widthConstraint:300
delegate:nil];
XCTAssertTrue(renderResult.succeeded);
[self assertRendering:renderResult fileName:fileName];
}
@catch (NSException *exception) {
NSString *exceptionMessage = [NSString stringWithFormat:@"%@", exception];
printf("Render Failed while rendering %s\n%s", [fileName UTF8String], [exceptionMessage UTF8String]);
XCTAssertTrue(NO);
XCTMutableIssue *issue = [[XCTMutableIssue alloc] initWithType:XCTIssueTypeAssertionFailure compactDescription:[NSString stringWithFormat:@"Rendering Exception in %@", fileName]];
[self recordIssue:issue];
}
}
}
@catch (NSException *exception) {
printf("Parsing Failed %s\n", [fileName UTF8String]);
for (NSError *parseError in cardParseResult.parseErrors) {
printf("%s\n", [parseError.userInfo[NSLocalizedDescriptionKey] UTF8String]);
}
XCTAssertTrue(NO);
[self assertParsing:cardParseResult fileName:fileName];
}
}
}

- (void)assertParsing:(ACOAdaptiveCardParseResult *)parseResult fileName:(NSString *)fileName
{
if (!parseResult.isValid) {
NSMutableArray<NSString *> *errorMsgs = [[NSMutableArray alloc] init];
for (NSError *parseError in parseResult.parseErrors) {
[errorMsgs addObject:parseError.userInfo[NSLocalizedDescriptionKey]];
}
XCTMutableIssue *issue = [[XCTMutableIssue alloc] initWithType:XCTIssueTypeAssertionFailure compactDescription:[NSString stringWithFormat:@" %@ in %@", [errorMsgs componentsJoinedByString:@", "], fileName]];
[self recordIssue:issue];
}
}

- (void)assertRendering:(ACRRenderResult *)renderResult fileName:(NSString *)fileName
{
if (!renderResult.succeeded) {
XCTMutableIssue *issue = [[XCTMutableIssue alloc] initWithType:XCTIssueTypeAssertionFailure compactDescription:[NSString stringWithFormat:@"Rendering Failure in %@", fileName]];
[self recordIssue:issue];
}
}

- (void)testParsingAndRenderingAllCards
{
NSBundle *main = [NSBundle mainBundle];
Expand Down