From 42a0c884dfa09ae3fa75f4b80c0e2e4d20e3bb58 Mon Sep 17 00:00:00 2001 From: tom Date: Tue, 6 Jun 2023 20:45:52 +0100 Subject: [PATCH 1/3] Update doc and config schema for tre_id --- config_schema.json | 2 +- docs/tre-admins/environment-variables.md | 2 +- .../setup-instructions/cicd-pre-deployment-steps.md | 2 +- docs/tre-admins/setup-instructions/setup-auth-entities.md | 2 +- docs/tre-admins/setup-instructions/workflows.md | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config_schema.json b/config_schema.json index e0cc14b522..d67bde4695 100644 --- a/config_schema.json +++ b/config_schema.json @@ -13,7 +13,7 @@ "tre_id": { "description": "TRE unique identifier", "type": "string", - "pattern": "^[a-zA-Z 0-9\\_]*$", + "pattern": "^[a-z]*$", "maxLength": 11 }, "management": { diff --git a/docs/tre-admins/environment-variables.md b/docs/tre-admins/environment-variables.md index cbe881d621..23eab0cf3e 100644 --- a/docs/tre-admins/environment-variables.md +++ b/docs/tre-admins/environment-variables.md @@ -21,7 +21,7 @@ |
Environment variable name
| Description | | ------------------------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `mytre-dev` will result in a resource group name for Azure TRE instance of `rg-mytre-dev`. This must be less than 12 characters. Allowed characters: Alphanumeric and underscores| +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `mytre-dev` will result in a resource group name for Azure TRE instance of `rg-mytre-dev`. This must be less than 12 characters. Allowed characters: lowercase letters| | `TRE_URL`| This will be generated for you by populating your `TRE_ID`. This is used so that you can automatically register bundles | | `CORE_ADDRESS_SPACE` | The address space for the Azure TRE core virtual network. `/22` or larger. | | `TRE_ADDRESS_SPACE` | The address space for the whole TRE environment virtual network where workspaces networks will be created (can include the core network as well). E.g. `10.0.0.0/12`| diff --git a/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md b/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md index 1152cb704d..03832704c0 100644 --- a/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md +++ b/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md @@ -62,7 +62,7 @@ Configure the following secrets in your github environment: |
Secret name
| Description | | ----------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: Alphanumeric, underscores, and hyphens. | +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase letters. | | `MGMT_RESOURCE_GROUP_NAME` | The name of the shared resource group for all Azure TRE core resources. | | `MGMT_STORAGE_ACCOUNT_NAME` | The name of the storage account to hold the Terraform state and other deployment artifacts. E.g. `mystorageaccount`. | | `ACR_NAME` | A globally unique name for the Azure Container Registry (ACR) that will be created to store deployment images. | diff --git a/docs/tre-admins/setup-instructions/setup-auth-entities.md b/docs/tre-admins/setup-instructions/setup-auth-entities.md index 04831cefbd..45e42c4c55 100644 --- a/docs/tre-admins/setup-instructions/setup-auth-entities.md +++ b/docs/tre-admins/setup-instructions/setup-auth-entities.md @@ -19,7 +19,7 @@ Next, you will set the configuration variables for the specific Azure TRE instan The rest of the variables can have their default values. -1. Decide on a name for your `tre_id`, which is an alphanumeric (with underscores allowed) ID for the Azure TRE instance. The value will be used in various Azure resources and AAD application names. It **needs to be globally unique and less than 12 characters in length**. Use only lowercase letters. Choose wisely! +1. Decide on a name for your `tre_id` ID for the Azure TRE instance. The value will be used in various Azure resources and AAD application names. It **needs to be globally unique and less than 12 characters in length**. Use **only** lowercase letters. Choose wisely! 1. Once you have decided on which AD Tenant paradigm, then you should be able to set `aad_tenant_id` in the authentication section in your `config.yaml` file. 1. Your AAD Tenant Admin can now use the terminal window in Visual Studio Code to execute the following script from within the development container to create all the AAD Applications that are used for TRE. The details of the script are covered in the [auth document](../auth.md). diff --git a/docs/tre-admins/setup-instructions/workflows.md b/docs/tre-admins/setup-instructions/workflows.md index d6fb3b2587..187ceab6d8 100644 --- a/docs/tre-admins/setup-instructions/workflows.md +++ b/docs/tre-admins/setup-instructions/workflows.md @@ -63,7 +63,7 @@ Configure the TRE ID and LOCATION repository secrets |
Secret name
| Description | | ----------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: Alphanumeric and underscores. | +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase letters. | | `LOCATION` | The Azure location (region) for all resources. E.g. `westeurope` | ### Create app registrations for API authentication @@ -123,7 +123,7 @@ Configure additional secrets used in the deployment workflow: |
Secret name
| Description | | ----------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: Alphanumeric, underscores, and hyphens. | +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase letters. | | `MGMT_RESOURCE_GROUP_NAME` | The name of the shared resource group for all Azure TRE core resources. | | `MGMT_STORAGE_ACCOUNT_NAME` | The name of the storage account to hold the Terraform state and other deployment artifacts. E.g. `mystorageaccount`. | | `ACR_NAME` | A globally unique name for the Azure Container Registry (ACR) that will be created to store deployment images. | From 9e8899d0dc67516d0d983c0f76584d209ebb9580 Mon Sep 17 00:00:00 2001 From: tom Date: Wed, 7 Jun 2023 08:44:04 +0100 Subject: [PATCH 2/3] Allow numbers too --- config_schema.json | 2 +- docs/tre-admins/environment-variables.md | 2 +- .../setup-instructions/cicd-pre-deployment-steps.md | 2 +- docs/tre-admins/setup-instructions/setup-auth-entities.md | 2 +- docs/tre-admins/setup-instructions/workflows.md | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config_schema.json b/config_schema.json index d67bde4695..31eec8c71d 100644 --- a/config_schema.json +++ b/config_schema.json @@ -8,7 +8,7 @@ "location": { "description": "The Azure location (region) for all resources.", "type": "string", - "pattern": "[a-z]+" + "pattern": "[a-z0-9]+" }, "tre_id": { "description": "TRE unique identifier", diff --git a/docs/tre-admins/environment-variables.md b/docs/tre-admins/environment-variables.md index 23eab0cf3e..a998198d81 100644 --- a/docs/tre-admins/environment-variables.md +++ b/docs/tre-admins/environment-variables.md @@ -21,7 +21,7 @@ |
Environment variable name
| Description | | ------------------------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `mytre-dev` will result in a resource group name for Azure TRE instance of `rg-mytre-dev`. This must be less than 12 characters. Allowed characters: lowercase letters| +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `mytre-dev` will result in a resource group name for Azure TRE instance of `rg-mytre-dev`. This must be less than 12 characters. Allowed characters: lowercase alphanumerics| | `TRE_URL`| This will be generated for you by populating your `TRE_ID`. This is used so that you can automatically register bundles | | `CORE_ADDRESS_SPACE` | The address space for the Azure TRE core virtual network. `/22` or larger. | | `TRE_ADDRESS_SPACE` | The address space for the whole TRE environment virtual network where workspaces networks will be created (can include the core network as well). E.g. `10.0.0.0/12`| diff --git a/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md b/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md index 03832704c0..d089d1967d 100644 --- a/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md +++ b/docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md @@ -62,7 +62,7 @@ Configure the following secrets in your github environment: |
Secret name
| Description | | ----------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase letters. | +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase alphanumerics. | | `MGMT_RESOURCE_GROUP_NAME` | The name of the shared resource group for all Azure TRE core resources. | | `MGMT_STORAGE_ACCOUNT_NAME` | The name of the storage account to hold the Terraform state and other deployment artifacts. E.g. `mystorageaccount`. | | `ACR_NAME` | A globally unique name for the Azure Container Registry (ACR) that will be created to store deployment images. | diff --git a/docs/tre-admins/setup-instructions/setup-auth-entities.md b/docs/tre-admins/setup-instructions/setup-auth-entities.md index 45e42c4c55..dc4f91b91b 100644 --- a/docs/tre-admins/setup-instructions/setup-auth-entities.md +++ b/docs/tre-admins/setup-instructions/setup-auth-entities.md @@ -19,7 +19,7 @@ Next, you will set the configuration variables for the specific Azure TRE instan The rest of the variables can have their default values. -1. Decide on a name for your `tre_id` ID for the Azure TRE instance. The value will be used in various Azure resources and AAD application names. It **needs to be globally unique and less than 12 characters in length**. Use **only** lowercase letters. Choose wisely! +1. Decide on a name for your `tre_id` ID for the Azure TRE instance. The value will be used in various Azure resources and AAD application names. It **needs to be globally unique and less than 12 characters in length**. Use **only** lowercase alphanumerics. Choose wisely! 1. Once you have decided on which AD Tenant paradigm, then you should be able to set `aad_tenant_id` in the authentication section in your `config.yaml` file. 1. Your AAD Tenant Admin can now use the terminal window in Visual Studio Code to execute the following script from within the development container to create all the AAD Applications that are used for TRE. The details of the script are covered in the [auth document](../auth.md). diff --git a/docs/tre-admins/setup-instructions/workflows.md b/docs/tre-admins/setup-instructions/workflows.md index 187ceab6d8..28db90d053 100644 --- a/docs/tre-admins/setup-instructions/workflows.md +++ b/docs/tre-admins/setup-instructions/workflows.md @@ -63,7 +63,7 @@ Configure the TRE ID and LOCATION repository secrets |
Secret name
| Description | | ----------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase letters. | +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase alphanumerics. | | `LOCATION` | The Azure location (region) for all resources. E.g. `westeurope` | ### Create app registrations for API authentication @@ -123,7 +123,7 @@ Configure additional secrets used in the deployment workflow: |
Secret name
| Description | | ----------- | ----------- | -| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase letters. | +| `TRE_ID` | A globally unique identifier. `TRE_ID` can be found in the resource names of the Azure TRE instance; for example, a `TRE_ID` of `tre-dev-42` will result in a resource group name for Azure TRE instance of `rg-tre-dev-42`. This must be less than 12 characters. Allowed characters: lowercase alphanumerics. | | `MGMT_RESOURCE_GROUP_NAME` | The name of the shared resource group for all Azure TRE core resources. | | `MGMT_STORAGE_ACCOUNT_NAME` | The name of the storage account to hold the Terraform state and other deployment artifacts. E.g. `mystorageaccount`. | | `ACR_NAME` | A globally unique name for the Azure Container Registry (ACR) that will be created to store deployment images. | From 489b6ac8b02106aaa7f1fe995f717af47ffb202a Mon Sep 17 00:00:00 2001 From: tom Date: Wed, 7 Jun 2023 09:03:52 +0100 Subject: [PATCH 3/3] Update the correct field --- config_schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config_schema.json b/config_schema.json index 31eec8c71d..0d2a781578 100644 --- a/config_schema.json +++ b/config_schema.json @@ -8,12 +8,12 @@ "location": { "description": "The Azure location (region) for all resources.", "type": "string", - "pattern": "[a-z0-9]+" + "pattern": "[a-z]+" }, "tre_id": { "description": "TRE unique identifier", "type": "string", - "pattern": "^[a-z]*$", + "pattern": "^[a-z0-9]*$", "maxLength": 11 }, "management": {