From a7c1fa8422a7570cc3d5bf77faac8a6bba543960 Mon Sep 17 00:00:00 2001 From: Alexander Holstrup <117829001+aholstrup1@users.noreply.github.com> Date: Wed, 28 Feb 2024 08:44:44 +0100 Subject: [PATCH] [releases/24.0] Return rather than exit strictmode when tag isn't present (#652) This pull request backports #641 to releases/24.0 + Reenable strict mode Fixes [AB#502108](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502108) --- build/projects/Business Foundation/.AL-Go/settings.json | 2 +- build/projects/Performance Toolkit/.AL-Go/settings.json | 2 +- build/projects/System Application/.AL-Go/settings.json | 2 +- build/projects/Test Framework/.AL-Go/settings.json | 2 +- build/scripts/PreCompileApp.ps1 | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/build/projects/Business Foundation/.AL-Go/settings.json b/build/projects/Business Foundation/.AL-Go/settings.json index 63dd82e438..f15aa7edbb 100644 --- a/build/projects/Business Foundation/.AL-Go/settings.json +++ b/build/projects/Business Foundation/.AL-Go/settings.json @@ -17,7 +17,7 @@ "releases/*.[0-5]" ], "settings": { - "buildModes": [ ] + "buildModes": [ "Strict" ] } } ] diff --git a/build/projects/Performance Toolkit/.AL-Go/settings.json b/build/projects/Performance Toolkit/.AL-Go/settings.json index 1cacd7768c..55c006ef92 100644 --- a/build/projects/Performance Toolkit/.AL-Go/settings.json +++ b/build/projects/Performance Toolkit/.AL-Go/settings.json @@ -13,7 +13,7 @@ "releases/*.[0-5]" ], "settings": { - "buildModes": [ ] + "buildModes": [ "Strict" ] } } ] diff --git a/build/projects/System Application/.AL-Go/settings.json b/build/projects/System Application/.AL-Go/settings.json index 016e41009b..cc82d57b1b 100644 --- a/build/projects/System Application/.AL-Go/settings.json +++ b/build/projects/System Application/.AL-Go/settings.json @@ -13,7 +13,7 @@ "releases/*.[0-5]" ], "settings": { - "buildModes": [ "Translated" ] + "buildModes": [ "Translated", "Strict"] } } ] diff --git a/build/projects/Test Framework/.AL-Go/settings.json b/build/projects/Test Framework/.AL-Go/settings.json index 7e8f66bfd5..9ae92b5e8e 100644 --- a/build/projects/Test Framework/.AL-Go/settings.json +++ b/build/projects/Test Framework/.AL-Go/settings.json @@ -14,7 +14,7 @@ "releases/*.[0-5]" ], "settings": { - "buildModes": [ "Translated" ] + "buildModes": [ "Translated", "Strict"] } } ] diff --git a/build/scripts/PreCompileApp.ps1 b/build/scripts/PreCompileApp.ps1 index c642bbc59c..886a80cd3b 100644 --- a/build/scripts/PreCompileApp.ps1 +++ b/build/scripts/PreCompileApp.ps1 @@ -57,7 +57,7 @@ if($appType -eq 'app') if(($appBuildMode -eq 'Strict') -and !(Test-IsStrictModeEnabled)) { Write-Host "::Warning:: Strict mode is not enabled for this branch. Exiting without enabling the strict mode breaking changes check." - exit + return } Enable-BreakingChangesCheck -AppSymbolsFolder $parameters.Value["appSymbolsFolder"] -AppProjectFolder $parameters.Value["appProjectFolder"] -BuildMode $appBuildMode | Out-Null