From 35d6e7fe0ba40131352fdeba7a94f070f0310cef Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Thu, 2 Jan 2025 10:33:36 +0100 Subject: [PATCH 1/8] fields tagged --- .../src/Assisted Setup/AssistedSetup.Table.al | 24 ++++++++++++++++++- .../Assisted Setup/AssistedSetupLog.Table.al | 4 +++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al index a65f04202a..61a25d949f 100644 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al +++ b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al @@ -33,6 +33,7 @@ table 1803 "Assisted Setup" DataClassification = SystemMetadata; Caption = 'Name'; } +#if not CLEANSCHEMA19 field(3; "Order"; Integer) { DataClassification = SystemMetadata; @@ -41,6 +42,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Order cannot be determined at compile time because the extensions that add to the table are unknown and can insert records in any order.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(4; Status; Option) { DataClassification = SystemMetadata; @@ -51,6 +54,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Only option used is Complete- new boolean field with that name created.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(5; Visible; Boolean) { DataClassification = SystemMetadata; @@ -59,6 +64,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Only those setup records that are visible should be added.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(6; Parent; Integer) { DataClassification = SystemMetadata; @@ -67,6 +74,7 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Hierarchy is removed. Instead the Group Name is populated for each record.'; ObsoleteTag = '19.0'; } +#endif field(7; "Video Url"; Text[250]) { DataClassification = SystemMetadata; @@ -77,6 +85,7 @@ table 1803 "Assisted Setup" DataClassification = SystemMetadata; Caption = 'Icon'; } +#if not CLEANSCHEMA19 field(9; "Item Type"; Option) { DataClassification = SystemMetadata; @@ -88,6 +97,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'No group type items anymore. Use the Group Name field instead.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(10; Featured; Boolean) { DataClassification = SystemMetadata; @@ -96,11 +107,13 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Not used in any UI component.'; ObsoleteTag = '19.0'; } +#endif field(11; "Help Url"; Text[250]) { DataClassification = CustomerContent; Caption = 'Help Url'; } +#if not CLEANSCHEMA19 field(12; "Assisted Setup Page ID"; Integer) { DataClassification = SystemMetadata; @@ -109,6 +122,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Redundant field- duplication of Page ID field.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(13; "Tour Id"; Integer) { DataClassification = SystemMetadata; @@ -117,6 +132,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Not used in any UI component.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(14; "Video Status"; Boolean) { DataClassification = SystemMetadata; @@ -125,6 +142,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Not needed to track if user has seen video.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(15; "Help Status"; Boolean) { DataClassification = SystemMetadata; @@ -133,6 +152,8 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Not needed to track if user has seen help.'; ObsoleteTag = '19.0'; } +#endif +#if not CLEANSCHEMA19 field(16; "Tour Status"; Boolean) { DataClassification = SystemMetadata; @@ -141,6 +162,7 @@ table 1803 "Assisted Setup" ObsoleteReason = 'Not used in any UI component.'; ObsoleteTag = '19.0'; } +#endif field(19; "App ID"; Guid) { Caption = 'App ID'; @@ -195,4 +217,4 @@ table 1803 "Assisted Setup" Translation.Delete(Rec); end; } -#endif \ No newline at end of file +#endif diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al index 81f0493a11..6497082ed3 100644 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al +++ b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al @@ -36,6 +36,7 @@ table 1807 "Assisted Setup Log" DataClassification = SystemMetadata; Caption = 'Date Time'; } +#if not CLEANSCHEMA19 field(11; "Invoked Action"; Option) { DataClassification = SystemMetadata; @@ -46,6 +47,7 @@ table 1807 "Assisted Setup Log" ObsoleteReason = 'Only videos opened are logged.'; ObsoleteTag = '19.0'; } +#endif } keys @@ -57,4 +59,4 @@ table 1807 "Assisted Setup Log" } } -#endif \ No newline at end of file +#endif From 977f2ae88aad16d090f58d529d5b6078b6c4571d Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Thu, 2 Jan 2025 10:48:44 +0100 Subject: [PATCH 2/8] Remove obsoleted fields and tables --- .../Legacy/ObsoleteSourceCodeExt.TableExt.al | 12 -- .../ObsoleteSourceCodeSetupExt.TableExt.al | 139 +----------------- .../src/Legacy/NoSeriesObsolete.TableExt.al | 10 -- .../Message/EmailMessageAttachment.Table.al | 9 -- .../AggregatedAssistedSetup.Table.al | 95 ------------ .../src/Assisted Setup/AssistedSetup.Table.al | 117 +-------------- .../AssistedSetupIcons.Table.al | 46 ------ .../Assisted Setup/AssistedSetupLog.Table.al | 14 +- .../ProductVideoCategory.Table.al | 56 ------- .../src/NetPromoterScoreSetup.Table.al | 10 -- .../App/Video/src/ProductVideoBuffer.Table.al | 19 --- 11 files changed, 3 insertions(+), 524 deletions(-) delete mode 100644 src/System Application/App/Guided Experience/src/Assisted Setup/AggregatedAssistedSetup.Table.al delete mode 100644 src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupIcons.Table.al delete mode 100644 src/System Application/App/Guided Experience/src/Assisted Setup/ProductVideoCategory.Table.al diff --git a/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeExt.TableExt.al b/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeExt.TableExt.al index 2131880597..e7334a2ff6 100644 --- a/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeExt.TableExt.al +++ b/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeExt.TableExt.al @@ -18,18 +18,6 @@ tableextension 230 ObsoleteSourceCodeExt extends "Source Code" MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972'; ObsoleteTag = '25.0'; } -#if not CLEANSCHEMA15 - field(10620; "SAFT Source Code"; Code[9]) - { - Caption = 'SAF-T Source Code'; - DataClassification = CustomerContent; - ObsoleteReason = 'Moved to extension'; - ObsoleteState = Removed; -#pragma warning disable AS0072 - ObsoleteTag = '15.0'; -#pragma warning restore AS0072 - } -#endif field(28160; Simulation; Boolean) { Caption = 'Simulation'; diff --git a/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al b/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al index d1bbc321ab..7a7be9442b 100644 --- a/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al +++ b/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al @@ -839,18 +839,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup" ObsoleteTag = '25.0'; MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972'; } -#if not CLEANSCHEMA15 - field(11200; "Inward Registration"; Code[10]) - { - Caption = 'Inward Registration'; - DataClassification = CustomerContent; - ObsoleteReason = 'Replaced by extension'; - ObsoleteState = Removed; -#pragma warning disable AS0072 - ObsoleteTag = '15.0'; -#pragma warning restore AS0072 - } -#endif field(11307; "Financial Journal"; Code[10]) { Caption = 'Financial Journal'; @@ -881,80 +869,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup" ObsoleteTag = '25.0'; MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972'; } -#if not CLEANSCHEMA20 - field(11760; "Purchase VAT Delay"; Code[10]) - { - Caption = 'Purchase VAT Delay'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Moved to Core Localization Pack for Czech.'; -#pragma warning disable AS0072 - ObsoleteTag = '20.0'; -#pragma warning restore AS0072 - } - field(11761; "Sales VAT Delay"; Code[10]) - { - Caption = 'Sales VAT Delay'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Moved to Core Localization Pack for Czech.'; -#pragma warning disable AS0072 - ObsoleteTag = '20.0'; -#pragma warning restore AS0072 - } -#endif -#if not CLEANSCHEMA18 - field(11762; "VAT Coefficient"; Code[10]) - { - Caption = 'VAT Coefficient'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'The functionality of Non-deductible VAT has been removed and this field should not be used.'; -#pragma warning disable AS0072 - ObsoleteTag = '18.0'; -#pragma warning restore AS0072 - } -#endif -#if not CLEANSCHEMA22 - field(11764; "Close Balance Sheet"; Code[10]) - { - Caption = 'Close Balance Sheet'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Moved to Core Localization Pack for Czech.'; -#pragma warning disable AS0072 - ObsoleteTag = '22.0'; -#pragma warning restore AS0072 - } - field(11765; "Open Balance Sheet"; Code[10]) - { - Caption = 'Open Balance Sheet'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Moved to Core Localization Pack for Czech.'; -#pragma warning disable AS0072 - ObsoleteTag = '22.0'; -#pragma warning restore AS0072 - } -#endif -#if not CLEANSCHEMA20 - field(11766; "Cash Desk"; Code[10]) - { - Caption = 'Cash Desk'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Moved to Cash Desk Localization for Czech.'; -#pragma warning disable AS0072 - ObsoleteTag = '20.0'; -#pragma warning restore AS0072 - } -#endif field(12400; "Advance Statements"; Code[10]) { Caption = 'Advance Statements'; @@ -1075,30 +989,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup" ObsoleteTag = '25.0'; MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972'; } -#if not CLEANSCHEMA21 - field(12450; "Item Receipt"; Code[10]) - { - Caption = 'Item Receipt'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteReason = 'Replaced by Inventory Documents feature.'; - ObsoleteState = Removed; -#pragma warning disable AS0072 - ObsoleteTag = '21.0'; -#pragma warning restore AS0072 - } - field(12451; "Item Shipment"; Code[10]) - { - Caption = 'Item Shipment'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteReason = 'Replaced by Inventory Documents feature.'; - ObsoleteState = Removed; -#pragma warning disable AS0072 - ObsoleteTag = '21.0'; -#pragma warning restore AS0072 - } -#endif field(12470; "FA Release"; Code[10]) { Caption = 'FA Release'; @@ -1159,32 +1049,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup" ObsoleteTag = '25.0'; MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972'; } -#if not CLEANSCHEMA18 - field(31041; "Maintenance Adjustment"; Code[10]) - { - Caption = 'Maintenance Adjustment'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'The functionality of Item consumption for FA maintenance will be removed and this field should not be used. (Obsolete::Removed in release 01.2021)'; -#pragma warning disable AS0072 - ObsoleteTag = '18.0'; -#pragma warning restore AS0072 - } -#endif -#if not CLEANSCHEMA21 - field(31050; Credit; Code[10]) - { - Caption = 'Credit'; - TableRelation = "Source Code"; - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Moved to Compensation Localization Pack for Czech.'; -#pragma warning disable AS0072 - ObsoleteTag = '21.0'; -#pragma warning restore AS0072 - } -#endif #pragma warning disable AS0013 field(2000020; "Domiciliation Journal"; Code[10]) { @@ -1231,5 +1095,4 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup" } #pragma warning restore AS0013 } -} - +} \ No newline at end of file diff --git a/src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesObsolete.TableExt.al b/src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesObsolete.TableExt.al index 9ca9b88762..d9ad844eb7 100644 --- a/src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesObsolete.TableExt.al +++ b/src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesObsolete.TableExt.al @@ -12,16 +12,6 @@ tableextension 308 NoSeriesObsolete extends "No. Series" { fields { -#if not CLEANSCHEMA18 - field(11790; Mask; Text[20]) // CZ Functionality - { - Caption = 'Mask'; - DataClassification = CustomerContent; - ObsoleteReason = 'The field is used in CZ localization only. The functionality of No. Series Enhancements will be removed and this field should not be used. (Obsolete::Removed in release 01.2021)'; - ObsoleteState = Removed; - ObsoleteTag = '18.0'; - } -#endif #pragma warning disable AL0432 field(12100; "No. Series Type"; Integer) #pragma warning restore AL0432 diff --git a/src/System Application/App/Email/src/Message/EmailMessageAttachment.Table.al b/src/System Application/App/Email/src/Message/EmailMessageAttachment.Table.al index 4cf14fc363..af35be9bbb 100644 --- a/src/System Application/App/Email/src/Message/EmailMessageAttachment.Table.al +++ b/src/System Application/App/Email/src/Message/EmailMessageAttachment.Table.al @@ -25,15 +25,6 @@ table 8904 "Email Message Attachment" DataClassification = SystemMetadata; TableRelation = "Email Message".Id; } -#if not CLEANSCHEMA18 - field(3; Attachment; Blob) - { - DataClassification = CustomerContent; - ObsoleteState = Removed; - ObsoleteReason = 'Field has been replaced with the media field, Data.'; - ObsoleteTag = '18.1'; - } -#endif field(4; "Attachment Name"; Text[250]) { DataClassification = CustomerContent; diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AggregatedAssistedSetup.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AggregatedAssistedSetup.Table.al deleted file mode 100644 index b20676bede..0000000000 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AggregatedAssistedSetup.Table.al +++ /dev/null @@ -1,95 +0,0 @@ -#if not CLEANSCHEMA19 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -table 1808 "Aggregated Assisted Setup" -{ - Access = Internal; - Caption = 'Aggregated Assisted Setup'; - ObsoleteState = Removed; - ObsoleteReason = 'Data available in Assisted Setup already- extensions also register in the same table.'; - ObsoleteTag = '19.0'; - ReplicateData = false; - - fields - { - field(1; "Page ID"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Page ID'; - } - field(2; Name; Text[250]) - { - DataClassification = SystemMetadata; - Caption = 'Name'; - } - field(3; "Order"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Order'; - } - field(4; Status; Option) - { - DataClassification = SystemMetadata; - Caption = 'Status'; - OptionCaption = 'Not Completed,Completed,Not Started,Seen,Watched,Read, '; - OptionMembers = "Not Completed",Completed,"Not Started",Seen,Watched,Read," "; - } - field(5; Visible; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Visible'; - } - field(8; Icon; Media) - { - DataClassification = SystemMetadata; - Caption = 'Icon'; - } - field(9; "Item Type"; Option) - { - DataClassification = SystemMetadata; - Caption = 'Item Type'; - InitValue = "Setup and Help"; - OptionCaption = ' ,Group,Setup and Help'; - OptionMembers = " ",Group,"Setup and Help"; - } - field(12; "Assisted Setup Page ID"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Assisted Setup Page ID'; - } - field(17; "External Assisted Setup"; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'External Assisted Setup'; - } - field(18; "Record ID"; RecordId) - { - Caption = 'Record ID'; - DataClassification = CustomerContent; - } - } - - keys - { - key(Key1; "Page ID") - { - Clustered = true; - } - key(Key2; "External Assisted Setup") - { - } - } - - fieldgroups - { - fieldgroup(Brick; Name, Status, Icon) - { - } - } -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al index 61a25d949f..a0ea50797a 100644 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al +++ b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al @@ -33,48 +33,6 @@ table 1803 "Assisted Setup" DataClassification = SystemMetadata; Caption = 'Name'; } -#if not CLEANSCHEMA19 - field(3; "Order"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Order'; - ObsoleteState = Removed; - ObsoleteReason = 'Order cannot be determined at compile time because the extensions that add to the table are unknown and can insert records in any order.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(4; Status; Option) - { - DataClassification = SystemMetadata; - Caption = 'Status'; - OptionCaption = 'Not Completed,Completed,Not Started,Seen,Watched,Read, '; - OptionMembers = "Not Completed",Completed,"Not Started",Seen,Watched,Read," "; - ObsoleteState = Removed; - ObsoleteReason = 'Only option used is Complete- new boolean field with that name created.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(5; Visible; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Visible'; - ObsoleteState = Removed; - ObsoleteReason = 'Only those setup records that are visible should be added.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(6; Parent; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Parent'; - ObsoleteState = Removed; - ObsoleteReason = 'Hierarchy is removed. Instead the Group Name is populated for each record.'; - ObsoleteTag = '19.0'; - } -#endif field(7; "Video Url"; Text[250]) { DataClassification = SystemMetadata; @@ -85,84 +43,11 @@ table 1803 "Assisted Setup" DataClassification = SystemMetadata; Caption = 'Icon'; } -#if not CLEANSCHEMA19 - field(9; "Item Type"; Option) - { - DataClassification = SystemMetadata; - Caption = 'Item Type'; - InitValue = "Setup and Help"; - OptionCaption = ' ,Group,Setup and Help'; - OptionMembers = " ",Group,"Setup and Help"; - ObsoleteState = Removed; - ObsoleteReason = 'No group type items anymore. Use the Group Name field instead.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(10; Featured; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Featured'; - ObsoleteState = Removed; - ObsoleteReason = 'Not used in any UI component.'; - ObsoleteTag = '19.0'; - } -#endif field(11; "Help Url"; Text[250]) { DataClassification = CustomerContent; Caption = 'Help Url'; } -#if not CLEANSCHEMA19 - field(12; "Assisted Setup Page ID"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Assisted Setup Page ID'; - ObsoleteState = Removed; - ObsoleteReason = 'Redundant field- duplication of Page ID field.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(13; "Tour Id"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Tour Id'; - ObsoleteState = Removed; - ObsoleteReason = 'Not used in any UI component.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(14; "Video Status"; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Video Status'; - ObsoleteState = Removed; - ObsoleteReason = 'Not needed to track if user has seen video.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(15; "Help Status"; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Help Status'; - ObsoleteState = Removed; - ObsoleteReason = 'Not needed to track if user has seen help.'; - ObsoleteTag = '19.0'; - } -#endif -#if not CLEANSCHEMA19 - field(16; "Tour Status"; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Tour Status'; - ObsoleteState = Removed; - ObsoleteReason = 'Not used in any UI component.'; - ObsoleteTag = '19.0'; - } -#endif field(19; "App ID"; Guid) { Caption = 'App ID'; @@ -217,4 +102,4 @@ table 1803 "Assisted Setup" Translation.Delete(Rec); end; } -#endif +#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupIcons.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupIcons.Table.al deleted file mode 100644 index 9487a79a4e..0000000000 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupIcons.Table.al +++ /dev/null @@ -1,46 +0,0 @@ -#if not CLEANSCHEMA19 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -table 1810 "Assisted Setup Icons" -{ - Access = Internal; - Caption = 'Assisted Setup Icons'; - DataPerCompany = false; - ReplicateData = false; - ObsoleteState = Removed; - ObsoleteReason = 'Icons are added directly from the extensions that add assisted setup, so no need to aggregate the icons here.'; - ObsoleteTag = '19.0'; - - fields - { - field(1; "No."; Code[50]) - { - DataClassification = CustomerContent; - Caption = 'No.'; - } - field(2; Image; Media) - { - DataClassification = CustomerContent; - Caption = 'Image'; - } - field(3; "Media Resources Ref"; Code[50]) - { - DataClassification = CustomerContent; - Caption = 'Media Resources Ref'; - } - } - - keys - { - key(Key1; "No.") - { - Clustered = true; - } - } -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al index 6497082ed3..f6d0ee02f4 100644 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al +++ b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al @@ -36,18 +36,6 @@ table 1807 "Assisted Setup Log" DataClassification = SystemMetadata; Caption = 'Date Time'; } -#if not CLEANSCHEMA19 - field(11; "Invoked Action"; Option) - { - DataClassification = SystemMetadata; - Caption = 'Invoked Action'; - OptionCaption = ' ,Video,Help,Tour,Assisted Setup'; - OptionMembers = " ",Video,Help,Tour,"Assisted Setup"; - ObsoleteState = Removed; - ObsoleteReason = 'Only videos opened are logged.'; - ObsoleteTag = '19.0'; - } -#endif } keys @@ -59,4 +47,4 @@ table 1807 "Assisted Setup Log" } } -#endif +#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/ProductVideoCategory.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/ProductVideoCategory.Table.al deleted file mode 100644 index f53199d29b..0000000000 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/ProductVideoCategory.Table.al +++ /dev/null @@ -1,56 +0,0 @@ -#if not CLEANSCHEMA19 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -table 1471 "Product Video Category" -{ - Access = Internal; - Caption = 'Product Video Category'; - ObsoleteState = Removed; - ObsoleteReason = 'Videos are not categorized any more in this way. The Video module handles the full listing.'; - ObsoleteTag = '19.0'; - ReplicateData = false; - - fields - { - field(1; ID; Integer) - { - DataClassification = SystemMetadata; - AutoIncrement = true; - Caption = 'ID'; - Editable = false; - } - field(2; Category; Option) - { - DataClassification = SystemMetadata; - Caption = 'Category'; - OptionCaption = ' ,Getting Started,,Finance & Bookkeeping,Sales,Reporting & BI,Inventory Management,Project Management,Workflows,Services & Extensions,Setup,Warehouse Management'; - OptionMembers = " ","Getting Started",,"Finance & Bookkeeping",Sales,"Reporting & BI","Inventory Management","Project Management",Workflows,"Services & Extensions",Setup,"Warehouse Management"; - } - field(3; "Assisted Setup ID"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Assisted Setup ID'; - TableRelation = "Guided Experience Item"."Object ID to Run"; - } - field(4; "Alternate Title"; Text[250]) - { - DataClassification = CustomerContent; - Caption = 'Alternate Title'; - } - } - - keys - { - key(Key1; "Assisted Setup ID", Category) - { - Clustered = true; - } - } - -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Satisfaction Survey/src/NetPromoterScoreSetup.Table.al b/src/System Application/App/Satisfaction Survey/src/NetPromoterScoreSetup.Table.al index 0a0abb1b25..8fd474857a 100644 --- a/src/System Application/App/Satisfaction Survey/src/NetPromoterScoreSetup.Table.al +++ b/src/System Application/App/Satisfaction Survey/src/NetPromoterScoreSetup.Table.al @@ -27,15 +27,6 @@ table 1432 "Net Promoter Score Setup" { DataClassification = SystemMetadata; } -#if not CLEANSCHEMA18 - field(4; "Time Between Requests"; Integer) - { - DataClassification = SystemMetadata; - ObsoleteReason = 'This field is not needed and it is not used anymore.'; - ObsoleteState = Removed; - ObsoleteTag = '18.0'; - } -#endif field(5; "Request Timeout"; Integer) { DataClassification = SystemMetadata; @@ -51,4 +42,3 @@ table 1432 "Net Promoter Score Setup" } } - diff --git a/src/System Application/App/Video/src/ProductVideoBuffer.Table.al b/src/System Application/App/Video/src/ProductVideoBuffer.Table.al index f8df4c3fbd..f93544744e 100644 --- a/src/System Application/App/Video/src/ProductVideoBuffer.Table.al +++ b/src/System Application/App/Video/src/ProductVideoBuffer.Table.al @@ -40,24 +40,6 @@ table 1470 "Product Video Buffer" DataClassification = SystemMetadata; Editable = false; } -#if not CLEANSCHEMA18 - field(4; "Assisted Setup ID"; Integer) - { - Caption = 'Assisted Setup ID'; - DataClassification = SystemMetadata; - ObsoleteState = Removed; - ObsoleteReason = 'All assisted setups shall be shown'; - ObsoleteTag = '18.0'; - } - field(5; Indentation; Integer) - { - Caption = 'Indentation'; - DataClassification = SystemMetadata; - ObsoleteState = Removed; - ObsoleteReason = 'Product videos are no more grouped.'; - ObsoleteTag = '18.0'; - } -#endif field(6; "Table Num"; Integer) { DataClassification = SystemMetadata; @@ -97,4 +79,3 @@ table 1470 "Product Video Buffer" } } } - From ad4dec20371352ac44d5ffad8da082f118a14391 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Thu, 2 Jan 2025 11:20:33 +0100 Subject: [PATCH 3/8] Fix upgrade code --- .../src/EmailAttachmentUpgrade.Codeunit.al | 44 ------------------- 1 file changed, 44 deletions(-) diff --git a/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al b/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al index 41d6379483..2686f0f250 100644 --- a/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al +++ b/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al @@ -18,47 +18,6 @@ codeunit 8910 "Email Attachment Upgrade" trigger OnUpgradePerCompany() begin - UpdateEmailAttachment() - end; - - local procedure UpdateEmailAttachment(); - var - UpgradeTag: Codeunit "Upgrade Tag"; - begin - if UpgradeTag.HasUpgradeTag(GetEmailAttachmentUpgradeTag()) then - exit; - - UpgradeEmailAttachments(); - - UpgradeTag.SetUpgradeTag(GetEmailAttachmentUpgradeTag()); - end; - - local procedure UpgradeEmailAttachments() - var - EmailMessageAttachment: Record "Email Message Attachment"; - begin - EmailMessageAttachment.SetAutoCalcFields(Attachment); - if not EmailMessageAttachment.FindSet() then - exit; - - repeat - MoveBlobToMedia(EmailMessageAttachment); - until EmailMessageAttachment.Next() = 0; - end; - - local procedure MoveBlobToMedia(EmailMessageAttachment: Record "Email Message Attachment") - var - AttachmentInstream: InStream; - begin - if not EmailMessageAttachment.Attachment.HasValue() then - exit; - - EmailMessageAttachment.Attachment.CreateInStream(AttachmentInstream); - if not IsNullGuid(EmailMessageAttachment.Data.ImportStream(AttachmentInstream, '')) then begin - Clear(EmailMessageAttachment.Attachment); - EmailMessageAttachment.Modify(); - end else - Session.LogMessage('0000CTY', StrSubstNo(MediaConversionMsg, EmailMessageAttachment.Length, EmailMessageAttachment."Content Type"), Verbosity::Error, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', EmailCategoryLbl); end; [EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", OnGetPerCompanyUpgradeTags, '', false, false)] @@ -72,7 +31,4 @@ codeunit 8910 "Email Attachment Upgrade" exit('MS-385494-EmailAttachmentToMedia-20210103'); end; - var - EmailCategoryLbl: Label 'Email', Locked = true; - MediaConversionMsg: Label 'Attachment with length: %1 and Content type: %2 Failed', Comment = '%1 - Attachment length, %2 - Content type', Locked = true; } From 966550b765d88f0864a9e725857c2c9d6a0c12fd Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Thu, 2 Jan 2025 12:06:29 +0100 Subject: [PATCH 4/8] obsoleted empty upgrade code --- .../App/Email/src/EmailAttachmentUpgrade.Codeunit.al | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al b/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al index 2686f0f250..53f0e89930 100644 --- a/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al +++ b/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al @@ -15,6 +15,9 @@ codeunit 8910 "Email Attachment Upgrade" Subtype = Upgrade; InherentPermissions = X; InherentEntitlements = X; + ObsoleteReason = 'Attachment field has been removed in version 26.'; + ObsoleteState = Pending; + ObsoleteTag = '26.0'; trigger OnUpgradePerCompany() begin From 0cece2d38a0804434ccb29f28bd079fa5768e89a Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Thu, 2 Jan 2025 12:07:22 +0100 Subject: [PATCH 5/8] removed trigger call --- .../App/Email/src/EmailAttachmentUpgrade.Codeunit.al | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al b/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al index 53f0e89930..35a603fa31 100644 --- a/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al +++ b/src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al @@ -19,10 +19,6 @@ codeunit 8910 "Email Attachment Upgrade" ObsoleteState = Pending; ObsoleteTag = '26.0'; - trigger OnUpgradePerCompany() - begin - end; - [EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", OnGetPerCompanyUpgradeTags, '', false, false)] local procedure RegisterPerCompanyTags(var PerCompanyUpgradeTags: List of [Code[250]]) begin From 61b53a785875556a71ea30154e97595f2628ef21 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Mon, 6 Jan 2025 09:21:18 +0100 Subject: [PATCH 6/8] Removed 23 and 24 as well --- .../ObsoleteSourceCodeSetupExt.TableExt.al | 13 --- .../src/Assisted Setup/AssistedSetup.Table.al | 105 ------------------ .../Assisted Setup/AssistedSetupLog.Table.al | 50 --------- .../Manual Setup/BusinessSetupIcon.Table.al | 49 -------- .../src/Manual Setup/ManualSetup.Table.al | 81 -------------- .../src/QueryNavigationValidation.Table.al | 51 --------- .../src/SmartListDesignerHandler.Table.al | 56 ---------- .../User Settings/src/ExtraSettings.Table.al | 44 -------- 8 files changed, 449 deletions(-) delete mode 100644 src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al delete mode 100644 src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al delete mode 100644 src/System Application/App/Guided Experience/src/Manual Setup/BusinessSetupIcon.Table.al delete mode 100644 src/System Application/App/Guided Experience/src/Manual Setup/ManualSetup.Table.al delete mode 100644 src/System Application/App/SmartList Designer Subscribers/src/QueryNavigationValidation.Table.al delete mode 100644 src/System Application/App/SmartList Designer Subscribers/src/SmartListDesignerHandler.Table.al delete mode 100644 src/System Application/App/User Settings/src/ExtraSettings.Table.al diff --git a/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al b/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al index 7a7be9442b..5319deefeb 100644 --- a/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al +++ b/src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al @@ -1070,19 +1070,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup" ObsoleteTag = '25.0'; MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972'; } -#if not CLEANSCHEMA24 - field(5005350; "Phys. Invt. Order"; Code[10]) - { - Caption = 'Phys. Invt. Order'; - ObsoleteReason = 'Merged to W1'; - DataClassification = CustomerContent; - ObsoleteState = Removed; - TableRelation = "Source Code"; -#pragma warning disable AS0072 - ObsoleteTag = '24.0'; -#pragma warning restore AS0072 - } -#endif field(7000000; "Cartera Journal"; Code[10]) { Caption = 'Cartera Journal'; diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al deleted file mode 100644 index a0ea50797a..0000000000 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetup.Table.al +++ /dev/null @@ -1,105 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -using System.Media; -using System.Globalization; -using System.Apps; - -table 1803 "Assisted Setup" -{ - Access = Internal; - InherentEntitlements = X; - InherentPermissions = X; - Caption = 'Assisted Setup'; - ReplicateData = false; - ObsoleteState = Removed; - ObsoleteTag = '23.0'; - ObsoleteReason = 'The Assisted Setup module and its objects have been consolidated in the Guided Experience module. Use the Guided Experience Item table instead.'; - - fields - { - field(1; "Page ID"; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Page ID'; - } - field(2; Name; Text[2048]) - { - DataClassification = SystemMetadata; - Caption = 'Name'; - } - field(7; "Video Url"; Text[250]) - { - DataClassification = SystemMetadata; - Caption = 'Video Url'; - } - field(8; Icon; Media) - { - DataClassification = SystemMetadata; - Caption = 'Icon'; - } - field(11; "Help Url"; Text[250]) - { - DataClassification = CustomerContent; - Caption = 'Help Url'; - } - field(19; "App ID"; Guid) - { - Caption = 'App ID'; - DataClassification = SystemMetadata; - Editable = false; - } - field(20; "Extension Name"; Text[250]) - { - Caption = 'Extension Name'; - FieldClass = FlowField; - CalcFormula = lookup("Published Application".Name where(ID = field("App ID"), "Tenant Visible" = const(true))); - Editable = false; - } - field(21; "Group Name"; Enum "Assisted Setup Group") - { - DataClassification = SystemMetadata; - Caption = 'Group'; - Editable = false; - } - field(22; Completed; Boolean) - { - DataClassification = SystemMetadata; - Caption = 'Completed'; - Editable = false; - } - field(23; "Video Category"; Enum "Video Category") - { - DataClassification = SystemMetadata; - Editable = false; - } - field(24; Description; Text[1024]) - { - DataClassification = CustomerContent; - Caption = 'Description'; - Editable = false; - } - } - - keys - { - key(Key1; "Page ID") - { - Clustered = true; - } - } - - - trigger OnDelete() - var - Translation: Codeunit Translation; - begin - Translation.Delete(Rec); - end; -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al deleted file mode 100644 index f6d0ee02f4..0000000000 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupLog.Table.al +++ /dev/null @@ -1,50 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -table 1807 "Assisted Setup Log" -{ - Access = Internal; - InherentEntitlements = X; - InherentPermissions = X; - Caption = 'Assisted Setup Log'; - ReplicateData = false; - ObsoleteState = Removed; - ObsoleteTag = '23.0'; - ObsoleteReason = 'The logs are not used.'; - - fields - { - field(1; "No."; Integer) - { - DataClassification = SystemMetadata; - AutoIncrement = true; - Caption = 'No.'; - } - field(3; "Entery No."; Integer) - { - DataClassification = SystemMetadata; - Caption = 'Entery No.'; - TableRelation = "Guided Experience Item"."Object ID to Run"; - } - field(10; "Date Time"; DateTime) - { - DataClassification = SystemMetadata; - Caption = 'Date Time'; - } - } - - keys - { - key(Key1; "No.") - { - Clustered = true; - } - } - -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Manual Setup/BusinessSetupIcon.Table.al b/src/System Application/App/Guided Experience/src/Manual Setup/BusinessSetupIcon.Table.al deleted file mode 100644 index e62ac36bee..0000000000 --- a/src/System Application/App/Guided Experience/src/Manual Setup/BusinessSetupIcon.Table.al +++ /dev/null @@ -1,49 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -table 1876 "Business Setup Icon" -{ - Access = Internal; - InherentEntitlements = X; - InherentPermissions = X; - Caption = 'Business Setup Icon'; - DataPerCompany = false; - ObsoleteState = Removed; - ObsoleteTag = '23.0'; - ObsoleteReason = 'The Manual Setup module and its objects have been consolidated in the Guided Experience module.'; - ReplicateData = false; - - fields - { - field(1; "Business Setup Name"; Text[50]) - { - DataClassification = CustomerContent; - Caption = 'Business Setup Name'; - } - field(2; Icon; Media) - { - DataClassification = CustomerContent; - Caption = 'Icon'; - } - field(3; "Media Resources Ref"; Code[50]) - { - DataClassification = CustomerContent; - Caption = 'Media Resources Ref'; - } - } - - keys - { - key(Key1; "Business Setup Name") - { - Clustered = true; - } - } - -} -#endif \ No newline at end of file diff --git a/src/System Application/App/Guided Experience/src/Manual Setup/ManualSetup.Table.al b/src/System Application/App/Guided Experience/src/Manual Setup/ManualSetup.Table.al deleted file mode 100644 index f1c21a7b96..0000000000 --- a/src/System Application/App/Guided Experience/src/Manual Setup/ManualSetup.Table.al +++ /dev/null @@ -1,81 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -using System.Apps; - -#pragma warning disable AS0039 -table 3700 "Manual Setup" -{ - Access = Internal; - InherentEntitlements = X; - InherentPermissions = X; - Caption = 'Manual Setup'; - TableType = Temporary; - - ObsoleteState = Removed; - ObsoleteTag = '23.0'; - ObsoleteReason = 'The Manual Setup module and its objects have been consolidated in the Guided Experience module. Use the Guided Experience Item table instead.'; - ReplicateData = false; - - fields - { - field(1; Name; Text[50]) - { - Caption = 'Name'; - } - field(2; "App ID"; Guid) - { - Caption = 'App ID'; - } - field(3; Description; Text[250]) - { - Caption = 'Description'; - } - field(4; Keywords; Text[250]) - { - Caption = 'Keywords'; - } - field(5; "Setup Page ID"; Integer) - { - Caption = 'Setup Page ID'; - } - field(6; Icon; Media) - { - Caption = 'Icon'; - } - field(7; "Extension Name"; Text[250]) - { - Caption = 'Extension Name'; - FieldClass = FlowField; - CalcFormula = lookup("Published Application".Name where(ID = field("App ID"))); - Editable = false; - } - field(8; Category; Enum "Manual Setup Category") - { - Caption = 'Category'; - Editable = false; - } - } - - keys - { - key(Key1; Name) - { - Clustered = true; - } - } - - fieldgroups - { - fieldgroup(Brick; Description, Name, Icon, Category) - { - } - } -} -#pragma warning restore AS0039 -#endif \ No newline at end of file diff --git a/src/System Application/App/SmartList Designer Subscribers/src/QueryNavigationValidation.Table.al b/src/System Application/App/SmartList Designer Subscribers/src/QueryNavigationValidation.Table.al deleted file mode 100644 index 44552b8385..0000000000 --- a/src/System Application/App/SmartList Designer Subscribers/src/QueryNavigationValidation.Table.al +++ /dev/null @@ -1,51 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Tooling; - -/// -/// Contains details about the results of validating Query Navigation data. -/// -table 2889 "Query Navigation Validation" -{ - DataClassification = SystemMetadata; - Extensible = false; - TableType = Temporary; - ReplicateData = false; - ObsoleteReason = 'The SmartList Designer is not supported in Business Central.'; - ObsoleteTag = '23.0'; - ObsoleteState = Removed; - - fields - { - /// - /// Simple primary key of the temporary table. - /// - field(1; PK; Integer) - { - AutoIncrement = true; - Access = Internal; - DataClassification = SystemMetadata; - } - - /// - /// Indicates the success/failure of the validation - /// - field(2; Valid; Boolean) - { - DataClassification = SystemMetadata; - } - - /// - /// Specifies a detailed message describing why the validation failed. - /// - field(3; Reason; Text[500]) - { - DataClassification = SystemMetadata; - } - } -} -#endif \ No newline at end of file diff --git a/src/System Application/App/SmartList Designer Subscribers/src/SmartListDesignerHandler.Table.al b/src/System Application/App/SmartList Designer Subscribers/src/SmartListDesignerHandler.Table.al deleted file mode 100644 index f232641780..0000000000 --- a/src/System Application/App/SmartList Designer Subscribers/src/SmartListDesignerHandler.Table.al +++ /dev/null @@ -1,56 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Tooling; - -/// -/// A single-record table that can be used to handle contention between multiple subscribers of the events for the SmartList Designer. -/// Consumers of the events should check this record to see if another extension is registered as the handler and then decide if they -/// should execute code within their own subscriptions to these events. Likewise, consumers could set this record to register themselves -/// as the handler of events. -/// -table 2888 "SmartList Designer Handler" -{ - DataPerCompany = false; - DataClassification = SystemMetadata; - Extensible = false; - ReplicateData = false; - ObsoleteState = Removed; - ObsoleteTag = '23.0'; - ObsoleteReason = 'The SmartList Designer is not supported in Business Central.'; - - fields - { - /// - /// The primary key of the table. As a single-record table this value - /// should only ever be set to the empty string ''. - /// - field(1; PrimaryKey; Code[10]) - { - Caption = 'Primary Key'; - DataClassification = SystemMetadata; - } - - /// - /// The AppId of the extension that has registered itself as the handler - /// of SmartList Designer events. - /// - field(2; HandlerExtensionId; Guid) - { - Caption = 'Handler Extension Id'; - DataClassification = SystemMetadata; - } - } - - keys - { - key(PK; PrimaryKey) - { - Clustered = true; - } - } -} -#endif \ No newline at end of file diff --git a/src/System Application/App/User Settings/src/ExtraSettings.Table.al b/src/System Application/App/User Settings/src/ExtraSettings.Table.al deleted file mode 100644 index 7f1c52f3f8..0000000000 --- a/src/System Application/App/User Settings/src/ExtraSettings.Table.al +++ /dev/null @@ -1,44 +0,0 @@ -#if not CLEANSCHEMA23 -// ------------------------------------------------------------------------------------------------ -// Copyright (c) Microsoft Corporation. All rights reserved. -// Licensed under the MIT License. See License.txt in the project root for license information. -// ------------------------------------------------------------------------------------------------ - -namespace System.Environment.Configuration; - -/// -/// Table that saves settings the Application defines. -/// -table 9173 "Extra Settings" -{ - Access = Internal; - InherentEntitlements = rimX; - InherentPermissions = rimX; - DataPerCompany = false; - ObsoleteState = Removed; - ObsoleteTag = '23.0'; - ObsoleteReason = 'Replaced with table 9222 "Application User Settings".'; - ReplicateData = false; - - fields - { - field(1; "User Security ID"; Guid) - { - DataClassification = EndUserIdentifiableInformation; - } - - field(2; "Teaching Tips"; Boolean) - { - DataClassification = CustomerContent; - } - } - - keys - { - key(PK; "User Security ID") - { - Clustered = true; - } - } -} -#endif \ No newline at end of file From cdbb0e4cb134e87049605ca22684817773bdad57 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Mon, 6 Jan 2025 13:47:17 +0100 Subject: [PATCH 7/8] Fixed upgrade code --- .../AssistedSetupUpgrade.Codeunit.al | 78 +------------------ .../src/UserSettingsUpgrade.Codeunit.al | 31 +------- 2 files changed, 7 insertions(+), 102 deletions(-) diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al index 47cd06c67d..0be11af261 100644 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al +++ b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al @@ -5,85 +5,13 @@ namespace System.Environment.Configuration; -using System.Upgrade; -using System.Globalization; - codeunit 1807 "Assisted Setup Upgrade" { Subtype = Upgrade; InherentEntitlements = X; InherentPermissions = X; Permissions = tabledata "Guided Experience Item" = r; - - trigger OnUpgradePerCompany() - begin - DeleteAssistedSetup(); - UpgradeToGuidedExperienceItem(); - end; - - procedure DeleteAssistedSetup() - var - AssistedSetup: Record "Assisted Setup"; - UpgradeTag: Codeunit "Upgrade Tag"; - AssistedSetupUpgradeTag: Codeunit "Assisted Setup Upgrade Tag"; - begin - if UpgradeTag.HasUpgradeTag(AssistedSetupUpgradeTag.GetDeleteAssistedSetupTag(), '') then - exit; - - if UpgradeTag.HasUpgradeTag(AssistedSetupUpgradeTag.GetDeleteAssistedSetupTag()) then - exit; - - AssistedSetup.DeleteAll(); - - UpgradeTag.SetUpgradeTag(AssistedSetupUpgradeTag.GetDeleteAssistedSetupTag()); - end; - - procedure UpgradeToGuidedExperienceItem() - var - GuidedExperienceItem: Record "Guided Experience Item"; - AssistedSetup: Record "Assisted Setup"; - UpgradeTag: Codeunit "Upgrade Tag"; - AssistedSetupUpgradeTag: Codeunit "Assisted Setup Upgrade Tag"; - begin - if UpgradeTag.HasUpgradeTag(AssistedSetupUpgradeTag.GetAssistedSetupToGuidedExperienceItemUpgradeTag(), '') then - exit; - - if UpgradeTag.HasUpgradeTag(AssistedSetupUpgradeTag.GetAssistedSetupToGuidedExperienceItemUpgradeTag()) then - exit; - - if AssistedSetup.FindSet() then - repeat - InsertAndGetGuidedExperienceItem(GuidedExperienceItem, AssistedSetup); - InsertTranslations(GuidedExperienceItem, AssistedSetup); - until AssistedSetup.Next() = 0; - - UpgradeTag.SetUpgradeTag(AssistedSetupUpgradeTag.GetAssistedSetupToGuidedExperienceItemUpgradeTag()); - end; - - local procedure InsertAndGetGuidedExperienceItem(var GuidedExperienceItem: Record "Guided Experience Item"; AssistedSetup: Record "Assisted Setup") - var - GuidedExperienceImpl: Codeunit "Guided Experience Impl."; - GuidedExperienceType: Enum "Guided Experience Type"; - ManualSetupCategory: Enum "Manual Setup Category"; - SpotlightTourType: Enum "Spotlight Tour Type"; - SpotlightTourTexts: Dictionary of [Enum "Spotlight Tour Text", Text]; - begin - GuidedExperienceImpl.Insert(AssistedSetup.Name, CopyStr(AssistedSetup.Name, 1, 50), AssistedSetup.Description, - 0, AssistedSetup."App ID", GuidedExperienceType::"Assisted Setup", ObjectType::Page, AssistedSetup."Page ID", - '', AssistedSetup."Group Name", AssistedSetup."Video Url", AssistedSetup."Video Category", - AssistedSetup."Help Url", ManualSetupCategory::Uncategorized, '', SpotlightTourType::None, SpotlightTourTexts, false); - - GuidedExperienceItem.SetRange("Guided Experience Type", GuidedExperienceItem."Guided Experience Type"::"Assisted Setup"); - GuidedExperienceItem.SetRange("Object Type to Run", GuidedExperienceItem."Object Type to Run"::Page); - GuidedExperienceItem.SetRange("Object ID to Run", AssistedSetup."Page ID"); - GuidedExperienceItem.SetRange(Link, ''); - if GuidedExperienceItem.FindLast() then; - end; - - local procedure InsertTranslations(GuidedExperienceItem: Record "Guided Experience Item"; AssistedSetup: Record "Assisted Setup") - var - Translation: Codeunit Translation; - begin - Translation.Copy(AssistedSetup, AssistedSetup.FieldNo(Name), GuidedExperienceItem, GuidedExperienceItem.FieldNo(Title)); - end; + ObsoleteReason = 'Table "Asssited Setup" has been removed in version 26.'; + ObsoleteState = Pending; + ObsoleteTag = '26.0'; } \ No newline at end of file diff --git a/src/System Application/App/User Settings/src/UserSettingsUpgrade.Codeunit.al b/src/System Application/App/User Settings/src/UserSettingsUpgrade.Codeunit.al index c0f9dcc66a..22a84aac5c 100644 --- a/src/System Application/App/User Settings/src/UserSettingsUpgrade.Codeunit.al +++ b/src/System Application/App/User Settings/src/UserSettingsUpgrade.Codeunit.al @@ -13,33 +13,10 @@ codeunit 9222 "User Settings Upgrade" Access = Internal; InherentEntitlements = X; InherentPermissions = X; - Permissions = tabledata "Extra Settings" = r, - tabledata "Application User Settings" = rim; - - trigger OnUpgradePerDatabase() - begin - TransferFieldsToApplicationUserSettings(); - end; - - local procedure TransferFieldsToApplicationUserSettings() - var - ExtraSettings: Record "Extra Settings"; - ApplicationUserSettings: Record "Application User Settings"; - UpgradeTag: Codeunit "Upgrade Tag"; - begin - if UpgradeTag.HasUpgradeTag(GetUserSettingsUpgradeTag()) then - exit; - - if ExtraSettings.FindSet() then - repeat - if not ApplicationUserSettings.Get(ExtraSettings."User Security ID") then begin - ApplicationUserSettings.TransferFields(ExtraSettings); - ApplicationUserSettings.Insert(); - end; - until ExtraSettings.Next() = 0; - - UpgradeTag.SetUpgradeTag(GetUserSettingsUpgradeTag()); - end; + Permissions = tabledata "Application User Settings" = rim; + ObsoleteState = Pending; + ObsoleteReason = 'Table "Extra Settings" has been removed in version 26.'; + ObsoleteTag = '26.0'; local procedure GetUserSettingsUpgradeTag(): Code[250] begin From 8a538d310c1c7ab2944b15921f6e887ccb6d83d7 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah Date: Mon, 6 Jan 2025 15:12:52 +0100 Subject: [PATCH 8/8] readded empty functions --- .../src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al index 0be11af261..4eefe045c0 100644 --- a/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al +++ b/src/System Application/App/Guided Experience/src/Assisted Setup/AssistedSetupUpgrade.Codeunit.al @@ -14,4 +14,12 @@ codeunit 1807 "Assisted Setup Upgrade" ObsoleteReason = 'Table "Asssited Setup" has been removed in version 26.'; ObsoleteState = Pending; ObsoleteTag = '26.0'; + + procedure DeleteAssistedSetup() + begin + end; + + procedure UpgradeToGuidedExperienceItem() + begin + end; } \ No newline at end of file