From 8496a34c033efed51c1232ce2c3a09c177ec9e3f Mon Sep 17 00:00:00 2001 From: Shuai Wang Date: Thu, 6 Feb 2020 01:32:23 +0800 Subject: [PATCH 1/2] fix: LU LSP suggest empty string entities and roles in entering utterance (#1889) * fix LU LSP suggest empty string entities and roles * fix comments Co-authored-by: Andy Brown --- .../language-understanding/src/matchingPattern.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts b/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts index 6f1cc9fec2..368768c2b9 100644 --- a/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts +++ b/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts @@ -130,7 +130,7 @@ export function getSuggestionEntities(luisJson: any, suggestionEntityTypes: stri suggestionEntityTypes.forEach(entityType => { if (luisJson[entityType] !== undefined && luisJson[entityType].length > 0) { luisJson[entityType].forEach(entity => { - if (entity) { + if (entity && entity.name) { suggestionEntityList.push(entity.name); } }); @@ -177,7 +177,9 @@ export function getSuggestionRoles(luisJson: any, suggestionEntityTypes: string[ luisJson[entityType].forEach(entity => { if (entity.roles !== undefined && entity.roles.length > 0) { entity.roles.forEach(role => { - suggestionRolesList.push(role); + if (role) { + suggestionRolesList.push(role); + } }); } }); From cf2bd0abceb1b9200d43bd76887d089b8809da95 Mon Sep 17 00:00:00 2001 From: Long Alan Date: Thu, 6 Feb 2020 02:23:10 +0800 Subject: [PATCH 2/2] style: update input node "other" size (#1950) --- .../extensions/visual-designer/src/constants/ElementSizes.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Composer/packages/extensions/visual-designer/src/constants/ElementSizes.ts b/Composer/packages/extensions/visual-designer/src/constants/ElementSizes.ts index b838a46645..4dd95df06c 100644 --- a/Composer/packages/extensions/visual-designer/src/constants/ElementSizes.ts +++ b/Composer/packages/extensions/visual-designer/src/constants/ElementSizes.ts @@ -17,8 +17,8 @@ export const LoopIconSize = { }; export const IconBrickSize = { - width: 16, - height: 16, + width: 24, + height: 24, }; export const LoopEdgeMarginLeft = 20;