Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple lg apis from editors (visual editor) #1761

Closed
yeze322 opened this issue Dec 11, 2019 · 2 comments
Closed

decouple lg apis from editors (visual editor) #1761

yeze322 opened this issue Dec 11, 2019 · 2 comments
Assignees
Labels
R8 Release 8 - March 16th, 2020 Type: Engineering

Comments

@yeze322
Copy link
Contributor

yeze322 commented Dec 11, 2019

currently, visual editor is invoking lg apis directly which causes unexpected http calls and potential redraws.

according to our previous work on extracting lg logic into lgutils and lgparser, decoupling lg logic will benefit us on editors' maintainability and improve overall engineering quality meanwhile reduce the migration cost when updating lg grammar version in composer.

based on the fact that lg lib itself is evolving outside the loop of composer and visualeditor, we need to inject lg apis in a more proper level. ideally, we can have a standalone module to map field value change to lg changes and finally triggers http calls. it could be shared accross visual and form.

@yeze322 yeze322 added Needs-triage A new issue that require triage Type: Engineering labels Dec 11, 2019
@hibrenda hibrenda added R8 Release 8 - March 16th, 2020 and removed Needs-triage A new issue that require triage labels Dec 12, 2019
@yeze322
Copy link
Contributor Author

yeze322 commented Dec 12, 2019

it's not completely done. one more pr required

@yeze322 yeze322 reopened this Dec 12, 2019
@yeze322
Copy link
Contributor Author

yeze322 commented Feb 3, 2020

item finished. close it

@yeze322 yeze322 closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020 Type: Engineering
Projects
None yet
Development

No branches or pull requests

2 participants