Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Label and Instruction - Property Pane]: Ensures every id attribute value is unique adaptive property pane #2142

Closed
ashish315 opened this issue Mar 2, 2020 · 1 comment

Comments

@ashish315
Copy link

User Experience
Screen reader user will face difficulty as it reads the irrelevant information because of providing the same id to other control.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
URL: Bot Framework Composer
Prerequisite Here

Repro Steps:

  1. Open the above mentioned URL in EDGE.
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
  4. Navigate to already created dialog tree item and activate it. Such as- Greetings, Actions, EndDialog etc.
  5. Click on "+" and select 'Ask a question'. Then select any of the available options except Oauth login.
  6. Navigate to property pane appeared at right side of the screen and select 'Bot Asks'.
  7. Run Accessibility insight and observe the issue.

Actual:
Adaptive property frame must have unique value Id attribute.

Expected:
Ensures every id attribute value is unique.

Note:
This accessibility issue was found using Accessibility Insights for Web 2.14.1 (axe-core 3.3.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Element path
.css-vaviek;.RecognizerField > .BaseField

Snippet
<div class="BaseField" id="Main_recognizer-892616">

How to fix
Fix any of the following:
Document has multiple static elements with the same id attribute

MAS Impacted: MAS4.1.1

Attachment:
Every Id attribute must be unique

@ashish315
Copy link
Author

Issue fixed in the latest build. So, HCL is closing the issue.

@ashish315 ashish315 removed the Fixed label Mar 12, 2020
@cwhitten cwhitten added Fixed and removed Fixed labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment