Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing InputHint support for IgnoringSpeechInput and IgnoringNonSpeechInput #9364

Closed
2 tasks done
stevengum opened this issue Aug 29, 2022 · 0 comments · Fixed by #9456
Closed
2 tasks done

Missing InputHint support for IgnoringSpeechInput and IgnoringNonSpeechInput #9364

stevengum opened this issue Aug 29, 2022 · 0 comments · Fixed by #9456
Assignees
@ceciliaavila
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working

Comments

@stevengum
Copy link
Member

Describe the bug

The latest official release of Composer does not include all five supported InputHints, just Accepting, Ignoring and Expecting.

Version

ac92152: ac92152b0f38a48e723ffe5bf8bf7351bc4edb3d

Version: 2.1.2
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution

OS

  • Windows

To Reproduce

  1. Create a new bot
  2. Add a Text prompt node to a topic
  3. Click on the plus sign next to Text in the right side menu
  4. Click Speech
  5. Open the Input hint dropdown
  6. See the options: "Accepting", "Ignoring" and "Expecting"

Expected behavior

See the "Accepting", "Ignoring" and "Expecting" InputHints along with "IgnoringSpeech" for ignoringSpeechInput, and "IgnoringNonSpeech" for ignoringNonSpeechInput

Screenshots

Step 6 from "To Reproduce" section with v2.1.2 release.

Composer screencapture
@stevengum stevengum added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Aug 29, 2022
@ceciliaavila ceciliaavila self-assigned this Dec 21, 2022
@ceciliaavila ceciliaavila mentioned this issue Dec 23, 2022
Merged
cwhitten added a commit that referenced this issue Feb 28, 2023
@ceciliaavila @NahuelPerales
@tracyboehrer @cwhitten
fix: [#9364] Missing InputHint support for IgnoringSpeechInput and Ig…
8300f37 
…noringNonSpeechInput (#9456)

* fix: add missing prompt options

* chore: revert extra changes

* add values to util.ts

* updated yarn-berry.lock

* Update yarn-berry.lock files

* Update yarn-berry.lock

---------

Co-authored-by: Nahuel Perales <nahuel.perales@southworks.com>
Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
@cwhitten cwhitten mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@stevengum @ceciliaavila