Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor styling and labeling for linting ux #1716

Merged
merged 2 commits into from
Dec 7, 2019
Merged

fix: minor styling and labeling for linting ux #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9a800
Minor deep-linking cleanup
cwhitten Dec 7, 2019
046119e
Update editor.schema label
cwhitten Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions Composer/packages/client/src/TestController.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,10 @@ export const TestController: React.FC = () => {
)}
<div ref={addRef}>
{showError && (
<Fragment>
<div style={{ float: 'left' }} onClick={handleErrorButtonClick}>
<span css={errorCount}>{errorLength}</span>
<IconButton
iconProps={{ iconName: 'ErrorBadge' }}
css={errorButton}
title="Error"
ariaLabel="Error"
onClick={handleErrorButtonClick}
/>
</Fragment>
<IconButton iconProps={{ iconName: 'ErrorBadge' }} css={errorButton} title="Error" ariaLabel="Error" />
</div>
)}
<PrimaryButton
css={botButton}
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/lib/shared/src/labelMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const ConceptLabels: { [key in ConceptLabelKey]?: LabelOverride } = {
title: formatMessage('Language Generation'),
},
[SDKTypes.AdaptiveDialog]: {
title: formatMessage('AdaptiveDialog'),
title: formatMessage('Adaptive dialog'),
},
[SDKTypes.AttachmentInput]: {
title: formatMessage('File or attachment'),
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/server/schemas/editor.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"Microsoft.AdaptiveDialog": {
"description": "This configures a data driven dialog via a collection of events and actions.",
"title": "AdaptiveDialog",
"title": "Adaptive dialog",
"helpLink": "https://aka.ms/botframework",
"helpLinkText": "Learn more"
},
Expand Down