Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: click on a inline lg template error it will navigate to design page and focus on the specific action #1856

Merged
merged 18 commits into from
Feb 6, 2020
Merged

feat: click on a inline lg template error it will navigate to design page and focus on the specific action #1856

merged 18 commits into from
Feb 6, 2020

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Jan 14, 2020 •
edited
Loading

Description

click on a inline lg template error it will navigate to design page and focus on the specific action.

Task Item

Closes #1742

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

4444

@liweitian liweitian requested a review from zhixzhan January 14, 2020 07:34
@liweitian liweitian changed the title Liweitian/navigate issue feat: click on a inline lg template error it will navigate to design page and focus on the specific action Jan 14, 2020
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Feb 4, 2020
@cwhitten cwhitten merged commit cdfc96d into microsoft:master Feb 6, 2020
@cwhitten cwhitten mentioned this pull request Feb 6, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhixzhan zhixzhan zhixzhan approved these changes

@lei9444 lei9444 lei9444 approved these changes

@boydc2014 boydc2014 boydc2014 approved these changes

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liweitian @cwhitten @boydc2014 @lei9444 @zhixzhan @a-b-r-o-w-n