fix: Packages stuck at "Installing package..." screen on network failure #9002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailure In case of a network failure, the error passed to the `importComponent` fn catch block doesn't contain `err.response.status` field, so it throws a new error preventing the modal from beeing closed. The PR adds an optional chaining operator for `error` to prevent the issue.
OEvgeny
requested review from
cwhitten,
boydc2014 and
a-b-r-o-w-n
as code owners
cwhitten
approved these changes
Feb 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When installing a package, in case of a network failure, the error passed to the
importComponentcatch block doesn't containerr.response.statusfield, so it throws a new error preventing the modal from being closed.The PR adds an optional chaining operator for
errorto prevent the issue.Task Item
The PR should fix the following a11y bug as well. Can't check this as narrator started to crash in this place after the fix (looks like a narrator bug)
Screenshots
#minor