Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#9346] Remove new line symbol from LGWidget #9435

Closed
wants to merge 4 commits into from

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #9346
#minor

Description

This PR solves part of an issue when rendering the LGWidget component (internal process to recognize language generation texts) to the Authoring Canvas UI.
Language generation texts that have multiple lines, new lines are being replaced with the ↵ symbol concatenating the texts into a single one causing the memory to increase when interacting in Composer.
By removing the new line symbol, and just leave the text as is (with the new lines only) reduced the amount of memory storage used.

Specific Changes

  • Removes the ↵ symbol from the useLgTemplate.ts file.
  • Updates unit test, removing use of the ↵ symbol.

Testing

The following image shows the before and after the applied fix, how the memory usage and the Authoring Canvas behaves.
image

@coveralls
Copy link

coveralls commented Nov 29, 2022

Coverage Status

Coverage: 54.555%. Remained the same when pulling f4ac6ae on southworks/update/lgwidget-newline-symbol into 66a028a on main.

@sw-joelmut
Copy link
Collaborator Author

Closed as it's no longer necessary

@sw-joelmut sw-joelmut closed this May 16, 2024
@OEvgeny OEvgeny deleted the southworks/update/lgwidget-newline-symbol branch May 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants