fix: bind composer server to localhost #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
force-pushed
the
fix/host-binding
branch
from
2ba5eb4
to
3de20dc
Compare
OEvgeny
requested review from
cwhitten,
boydc2014,
a-b-r-o-w-n,
srinaath,
benbrown,
tdurnford and
VamsiModem
as code owners
cwhitten
approved these changes
Jan 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bind composer server to localhost unless the host is specified by
COMPOSER_HOSTenvironment variable. The variable can be set to0.0.0.0to restore previous behavior for server builds only, (isn't supported in Electron currently).#minor