Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add typechecking to extension build script #9494

Merged
merged 5 commits into from
Jan 25, 2023
Merged

build: add typechecking to extension build script #9494

merged 5 commits into from
Jan 25, 2023

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Adds a typechecking step when building extensions to guard against type changes during package upgrades, etc.

Task Item

#minor

Screenshots

@coveralls
Copy link

coveralls commented Jan 25, 2023 •
edited
Loading

Coverage Status

Coverage: 54.564%. Remained the same when pulling 6f28d27 on abrown/extension-type-check into 7455bae on main.

@a-b-r-o-w-n
Copy link
Contributor Author

Note: this should start failing the build due to existing type errors in the extensions. The plan is to merge this to main so that future compile errors are caught.

tdurnford
tdurnford previously approved these changes Jan 25, 2023
View reviewed changes
tdurnford
tdurnford previously approved these changes Jan 25, 2023
View reviewed changes
@a-b-r-o-w-n a-b-r-o-w-n merged commit 77255fb into main Jan 25, 2023
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/extension-type-check branch January 25, 2023 20:53
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford left review comments

Assignees

@tdurnford tdurnford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @coveralls @tdurnford