Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id for conversation object #2129

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Apr 10, 2020

Signed-off-by: Srinaath Ravichandran srravich@microsoft.com
Fixes the first bullet in #2097
This PR is additive. It adds the field Id to the conversation object along with conversationId which already exists in the object

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.809% when pulling c35cd46 on srravich/bugfix/2097-conversation-id into 45d7cf1 on master.

@srinaath srinaath merged commit 3f6cec6 into master Apr 10, 2020
@tonyanziano tonyanziano deleted the srravich/bugfix/2097-conversation-id branch May 13, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants