Skip to content

Conversation

@Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request introduces a new GitHub Actions workflow to ensure the azure.yaml file includes a required template property for telemetry validation. The workflow checks for both the presence and proper formatting of the template line.

New GitHub Actions Workflow:

  • .github/workflows/telemetry-template-check.yml: Added a workflow named validate template property for telemetry that triggers on pull requests to the main branch when changes are made to azure.yaml. It verifies the presence and correct formatting of the template property in azure.yaml, ensuring it is not commented out and matches the required value.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow to validate that the azure.yaml file contains a properly formatted and uncommented template property for telemetry purposes. The workflow triggers on pull requests to the main branch when azure.yaml is modified.

  • Introduces automated validation for telemetry template property in azure.yaml
  • Ensures the template line is present and not commented out
  • Provides clear error messages for missing or commented template lines


steps:
- name: Checkout code
uses: actions/checkout@v3
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating to actions/checkout@v4 for better performance and latest features. The v3 version is older and may have security or compatibility issues.

Suggested change
uses: actions/checkout@v3
uses: actions/checkout@v4

Copilot uses AI. Check for mistakes.

jobs:
validate-template-property:
name : validate-template-property
Copy link

Copilot AI Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra space before the colon. YAML formatting should be consistent with 'name: validate-template-property'.

Suggested change
name : validate-template-property
name: validate-template-property

Copilot uses AI. Check for mistakes.
@Roopan-Microsoft Roopan-Microsoft merged commit 7a87cf5 into main Jul 11, 2025
8 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-us-20458 branch July 11, 2025 12:44
@github-actions
Copy link

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants