Skip to content

fix: Remove createdby from pipeline and add change Createdby logic in bice… #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

fix: Remove createdby from pipeline and add change Createdby logic in bice… #678

merged 3 commits into from
Sep 23, 2025

Conversation

@NirajC-Microsoft
Copy link
Contributor

@NirajC-Microsoft NirajC-Microsoft commented Sep 22, 2025

Purpose

This pull request makes minor improvements to deployment parameter handling in the workflow and Bicep infrastructure files. The most notable changes are a refinement to how the createdBy parameter is set and a cleanup of deployment parameters in the GitHub Actions workflow.

Deployment parameter handling:

  • In infra/main.bicep, the logic for the createdBy parameter is updated to check if userPrincipalName exists in the deployer object. If present, it uses the username part of the email; otherwise, it falls back to the deployer's objectId. This makes the assignment more robust in different deployment contexts.

Workflow parameter cleanup:

  • In .github/workflows/CAdeploy.yml, the createdBy parameter is removed from the Azure deployment command, likely because the Bicep file now handles this logic internally.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 2fcaf2b into dev Sep 23, 2025
5 checks passed
Roopan-Microsoft pushed a commit that referenced this pull request Sep 29, 2025
@NirajC-Microsoft @VishalS-Microsoft
@Harsh-Microsoft
fix: Dev to main (#681)
7a86f2c 
* fix: added tags in CAdeploy.yml file (#675)

* CI Pipeline fix for Client Advisor

* added tags in CAdeploy.yml file

* add my feature branch

* tags changes updated in CAdeploy.yml file

* added template name condition based

* removed my feature branch from pipeline

* Additional Troubleshooting steps

* fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678)

* Remove createdby from pipeline and add change Createdby logic in bicep file

* Add 'createdBy' parameter to Azure deployment

* Add 'createdBy' parameter for tagging

* added new 'type' tag (#682)

* Update docs/TroubleShootingSteps.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update GitHub Issues link in troubleshooting steps

---------

Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com>
Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Roopan-Microsoft pushed a commit that referenced this pull request Oct 1, 2025
@Vamshi-Microsoft @NirajC-Microsoft
@VishalS-Microsoft @Harsh-Microsoft @Prajwal-Microsoft
refactor: Update README, azure.yml for minimum azd version 1.18.0 & r…
1b49c5d 
…emoved the unsued params (#690)

* fix: Dev to main (#681)

* fix: added tags in CAdeploy.yml file (#675)

* CI Pipeline fix for Client Advisor

* added tags in CAdeploy.yml file

* add my feature branch

* tags changes updated in CAdeploy.yml file

* added template name condition based

* removed my feature branch from pipeline

* Additional Troubleshooting steps

* fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678)

* Remove createdby from pipeline and add change Createdby logic in bicep file

* Add 'createdBy' parameter to Azure deployment

* Add 'createdBy' parameter for tagging

* added new 'type' tag (#682)

* Update docs/TroubleShootingSteps.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update GitHub Issues link in troubleshooting steps

---------

Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com>
Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: Removed commented params

* Update README and azure.yml for minimum azd version 1.18.0

---------

Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com>
Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com>
Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Prajwal D C <v-dcprajwal@microsoft.com>
Roopan-Microsoft added a commit that referenced this pull request Oct 3, 2025
@Prajwal-Microsoft @VishalS-Microsoft
@NirajC-Microsoft @Harsh-Microsoft @Vamshi-Microsoft @Roopan-Microsoft
refactor: removed commented code, fixes for Standard Gallery validati…
e17125b 
…on & updated docs (#692)

* fix: added tags in CAdeploy.yml file (#675)

* CI Pipeline fix for Client Advisor

* added tags in CAdeploy.yml file

* add my feature branch

* tags changes updated in CAdeploy.yml file

* added template name condition based

* removed my feature branch from pipeline

* Additional Troubleshooting steps

* fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678)

* Remove createdby from pipeline and add change Createdby logic in bicep file

* Add 'createdBy' parameter to Azure deployment

* Add 'createdBy' parameter for tagging

* added new 'type' tag (#682)

* Create new Managed Identity for SQL operations with least privileges

* Update docs/TroubleShootingSteps.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update GitHub Issues link in troubleshooting steps

* removed SQL user assigned identity from key vault and SQL DB module

* Refactor DNS zone naming and update SQL database redundancy settings

* fix pylint issues

* refactor: Update README, azure.yml for minimum azd version 1.18.0 & removed the unsued params (#690)

* fix: Dev to main (#681)

* fix: added tags in CAdeploy.yml file (#675)

* CI Pipeline fix for Client Advisor

* added tags in CAdeploy.yml file

* add my feature branch

* tags changes updated in CAdeploy.yml file

* added template name condition based

* removed my feature branch from pipeline

* Additional Troubleshooting steps

* fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678)

* Remove createdby from pipeline and add change Createdby logic in bicep file

* Add 'createdBy' parameter to Azure deployment

* Add 'createdBy' parameter for tagging

* added new 'type' tag (#682)

* Update docs/TroubleShootingSteps.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update GitHub Issues link in troubleshooting steps

---------

Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com>
Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: Removed commented params

* Update README and azure.yml for minimum azd version 1.18.0

---------

Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com>
Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com>
Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Prajwal D C <v-dcprajwal@microsoft.com>

* Update Azure template validation action to latest version

* Update azure-dev.yml

* Update azure-dev.yml

* Chore: Disable Dev Container usage in Azure validation step

Disable the use of Dev Container for Azure template validation.

* chore: Refactor Azure DevOps workflow configuration

* fix: Rename main.bicep for network module

* chore: Update Azure template validation action version

* chore: Add validateTests parameter to Azure Dev workflow

* chore: Update Azure template validation action version

* fix post deployment script to support exp

* refactor: Comments fixed

---------

Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com>
Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com>
Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com>
Co-authored-by: Vamshi-Microsoft <v-vamolla@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

🎉 This PR is included in version 1.9.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roopan-Microsoft Roopan-Microsoft Roopan-Microsoft approved these changes

@Avijit-Microsoft Avijit-Microsoft Awaiting requested review from Avijit-Microsoft Avijit-Microsoft is a code owner

@Prajwal-Microsoft Prajwal-Microsoft Awaiting requested review from Prajwal-Microsoft Prajwal-Microsoft is a code owner

@Vinay-Microsoft Vinay-Microsoft Awaiting requested review from Vinay-Microsoft Vinay-Microsoft is a code owner

@aniaroramsft aniaroramsft Awaiting requested review from aniaroramsft aniaroramsft is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NirajC-Microsoft @Roopan-Microsoft