Skip to content

Conversation

@Abdul-Microsoft
Copy link
Contributor

Purpose

  • This pull request includes a minor update to the .github/workflows/CAdeploy.yml file, focusing on renaming a parameter to improve clarity and consistency.

Workflow improvement:

  • Updated the parameter name from AzureOpenAILocation to aiDeploymentsLocation in the Azure deployment command to align with naming conventions and improve readability. ([.github/workflows/CAdeploy.ymlL122-R122](https://github.com/microsoft/Build-your-own-copilot-Solution-Accelerator/pull/586/files#diff-67593888fa4a3b8c26f65fe9387615f60cda88c80b3eb1407e6330d5e8bb1468L122-R122))

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames a deployment parameter in the CAdeploy GitHub workflow to improve clarity and consistency.

  • Changed the parameter name from AzureOpenAILocation to aiDeploymentsLocation in the Azure CLI deployment command.
Comments suppressed due to low confidence (2)

.github/workflows/CAdeploy.yml:122

  • Verify that the infra/main.bicep template has been updated to accept aiDeploymentsLocation instead of AzureOpenAILocation; a mismatch will cause deployment failures.
            --parameters aiDeploymentsLocation=${{ env.AZURE_LOCATION }} environmentName=${{ env.SOLUTION_PREFIX }} cosmosLocation=eastus2 gptDeploymentCapacity=${{ env.GPT_MIN_CAPACITY }} embeddingDeploymentCapacity=${{ env.TEXT_EMBEDDING_MIN_CAPACITY }} \

.github/workflows/CAdeploy.yml:122

  • [nitpick] For consistency with other singular parameters like cosmosLocation, consider renaming aiDeploymentsLocation to aiDeploymentLocation.
            --parameters aiDeploymentsLocation=${{ env.AZURE_LOCATION }} environmentName=${{ env.SOLUTION_PREFIX }} cosmosLocation=eastus2 gptDeploymentCapacity=${{ env.GPT_MIN_CAPACITY }} embeddingDeploymentCapacity=${{ env.TEXT_EMBEDDING_MIN_CAPACITY }} \

@Roopan-Microsoft Roopan-Microsoft merged commit c7e0f6a into main Jul 2, 2025
8 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-fixCAdeploy branch July 2, 2025 13:52
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants