Recover ledger last idx from read-only ledger directory on recovery #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
host_ledger_recovery@15931 aka 20201130.8 vs master ewma over 50 builds from 15365 to 15926 |
jumaffre
changed the title
ashamis
approved these changes
Nov 28, 2020
achamayou
reviewed
Nov 30, 2020
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
achamayou
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the CI issues experienced on #1925
When recovering a ledger, we assumed that there was at least one ledger entry in the main ledger directory that could inform the ledger of the idx of the last entry (
last_idx). However, it is possible that only a read-only ledger directory (--read-only-ledger-diroption tocchost) was passed in.This PR fixes this issue by looking up all the ledger files in read-only ledger directories on start-up as well.