Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: require IEEE P1363 ECDSA signatures in ccf.crypto.verifySignature #2737

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

letmaik
Copy link
Member

@letmaik letmaik commented Jun 25, 2021

Fixes #2735.

@letmaik letmaik requested a review from a team June 25, 2021 15:09
@ghost
Copy link

ghost commented Jun 25, 2021

letmaik/js-ecdsa-p1363@28444 aka 20210706.12 vs main ewma over 20 builds from 28054 to 28438

Click to see table
build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_sgx_bft^ tpcc_sgx_bft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem CHAMP put (/s)^ CHAMP get (/s)^
28054 20210628.17 6330.62 9.13613e+07 3003.29 1.99103e+08 20496.1 1.74367e+07 4427.87 1.48153e+07 2540.68 9.31027e+06 2462.64 9.57242e+06 1726.6 8.78598e+06 1.32858e+06 3.62478e+07
28061 20210629.1 6542.57 9.26721e+07 2515.78 2.63066e+08 22568.4 1.74367e+07 4042.54 1.4291e+07 2551.89 1.35046e+07 2471.46 1.29803e+07 1744.93 8.52384e+06 1.34163e+06 3.61837e+07
28078 20210629.6 6335.71 9.21478e+07 2786.99 2.25055e+08 21492.1 1.74367e+07 4199.14 1.50774e+07 2590.95 9.31027e+06 2336.38 9.04813e+06 1777.41 8.2617e+06 1.32104e+06 3.63121e+07
28097 20210629.10 6452.73 9.26721e+07 3109.33 2.15355e+08 20964.8 1.71746e+07 4241.77 1.45532e+07 2608.67 9.31027e+06 2518.08 1.00967e+07 1793.79 8.2617e+06 1.3349e+06 3.67025e+07
28163 20210629.27 6512.25 9.26721e+07 2981.42 2.06443e+08 23637 1.82232e+07 3863.29 1.35046e+07 2663.48 9.57242e+06 2513.36 9.31027e+06 1778.71 8.2617e+06 1.35092e+06 3.62478e+07
28178 20210630.1 6436.02 9.26721e+07 2921.85 2.12734e+08 22414.4 1.74367e+07 4393.68 1.48153e+07 2614.19 9.83456e+06 2426.21 9.83456e+06 1704.73 8.2617e+06 1.35512e+06 3.62478e+07
28188 20210630.4 6728.84 9.10992e+07 2665.36 2.76959e+08 22043.4 1.74367e+07 4021.22 1.45532e+07 2526.56 9.31027e+06 2432.42 9.04813e+06 1733.85 8.52384e+06 1.34163e+06 3.61837e+07
28198 20210630.7 6299.82 9.26721e+07 3203.19 1.95695e+08 22806.7 1.74367e+07 4178.25 1.48153e+07 2643.08 1.00967e+07 2516.87 9.31027e+06 1728.78 8.2617e+06 1.33238e+06 3.67025e+07
28205 20210630.9 6618.6 9.18856e+07 3214.1 1.9019e+08 23533.1 1.76989e+07 4130.58 1.56017e+07 2576.87 9.31027e+06 2491.62 9.31027e+06 1739.19 8.2617e+06 1.35692e+06 3.65062e+07
28225 20210701.1 6305.29 9.05749e+07 2713.85 2.5625e+08 21895 1.76989e+07 4188.07 1.50774e+07 2573.45 9.83456e+06 2452.18 9.31027e+06 1725.82 8.52384e+06 1.33472e+06 3.69675e+07
28245 20210702.1 6520.96 9.05749e+07 3009.55 2.0985e+08 23314.6 1.74367e+07 4243.24 1.48153e+07 2577.16 9.57242e+06 2396.45 1.27181e+07 1773.66 8.2617e+06 1.35262e+06 3.61837e+07
28264 20210702.7 6640.26 9.16235e+07 2580.25 2.62804e+08 22515 1.74367e+07 4027.41 1.4291e+07 2670.77 9.31027e+06 2578.96 1.19317e+07 1700.31 8.52384e+06 1.32935e+06 3.59298e+07
28277 20210702.11 6331.32 9.10992e+07 3075.95 2.10375e+08 22464.2 1.74367e+07 4014.73 1.4291e+07 2557.44 9.57242e+06 2330.92 9.31027e+06 1685.92 8.52384e+06 1.34242e+06 3.59298e+07
28335 20210705.4 6240.41 9.18856e+07 3212.15 1.77082e+08 21304.1 1.74367e+07 4138.19 1.45532e+07 2651.31 9.31027e+06 2500.95 9.31027e+06 1704.86 8.52384e+06 1.31299e+06 3.61837e+07
28357 20210705.9 6615.18 9.37206e+07 3194.46 1.74461e+08 21695.3 1.74367e+07 4388.84 1.50774e+07 2527.32 9.57242e+06 2528.34 9.04813e+06 1768.94 8.52384e+06 1.34023e+06 3.62478e+07
28394 20210705.20 6471.83 9.10992e+07 3130.35 2.19812e+08 22903.6 1.74367e+07 4338.81 1.48153e+07 2605.5 9.57242e+06 2413.73 9.31027e+06 1758.01 1.00967e+07 1.3349e+06 3.62478e+07
28411 20210706.2 6409.07 9.13613e+07 2661.01 2.30298e+08 22950.7 1.74367e+07 4014.15 1.48153e+07 2576.64 9.57242e+06 2500.53 9.57242e+06 1731.57 8.52384e+06 1.33542e+06 3.69009e+07
28415 20210706.3 6563.1 9.16235e+07 3100.87 2.01462e+08 20278.4 1.74367e+07 4378.9 1.48153e+07 2635.76 9.57242e+06 2606.05 9.31027e+06 1653.03 9.31027e+06 1.34675e+06 3.59298e+07
28419 20210706.5 6288.48 9.18856e+07 3177.41 1.89665e+08 21434.2 1.74367e+07 4034.29 1.45532e+07 2702.66 9.83456e+06 2588.58 9.31027e+06 1765.41 8.52384e+06 1.34977e+06 3.53713e+07
28438 20210706.11 6556.78 9.29342e+07 2935.07 2.13783e+08 20822.4 1.71746e+07 3980.81 1.40289e+07 2704.48 9.57242e+06 2562.33 9.31027e+06 1796.76 8.2617e+06 1.37727e+06 3.69675e+07

images

@achamayou achamayou merged commit ce877fc into microsoft:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js: Assume IEEE P1363 encoding for ECDSA signatures in ccf.crypto.verifySignature
2 participants