Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorate and identify SNP libraries #4569

Merged
merged 21 commits into from
Nov 18, 2022
Merged

Decorate and identify SNP libraries #4569

merged 21 commits into from
Nov 18, 2022

Conversation

jumaffre
Copy link
Contributor

Resolves #4069 (last remaining item)

  1. Libraries/enclave apps built for SNP are now suffixed with .snp (rather than .virtual).
  2. Because of 1., the Python infra now needs to differentiate between these libraries based on CMake's COMPILE_TARGET.
  3. The enclave configuration entry now accepts a new "platform" field to differentiate between SGX, SNP and Virtual, while the existing "type" can now either be debug or release (only applies to SGX for now). Note that this isn't a breaking change for production deployment as the new "platform" field defaults to SGX.

@jumaffre jumaffre requested a review from a team November 16, 2022 17:49
@achamayou achamayou added auto-backport Automatically backport this PR to LTS branch 3.x-todo PRs which should be backported to 3.x labels Nov 16, 2022
@achamayou achamayou mentioned this pull request Nov 16, 2022
Closed
7 tasks
@ghost
Copy link

ghost commented Nov 17, 2022 •
edited by ghost
Loading

snp_artefacts_decorator@54946 aka 20221118.21 vs main ewma over 20 builds from 54188 to 54937

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem hist_sgx_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
54188 20221115.2 0.76281 17089.1 45920.6 12456.4 4485.59 3650.04 6297.84 8.21863e+07 3326.4 15949.1 1.50774e+07 25513.8 5686.21 1.50774e+07 1570.31 7.99955e+06 1287.12 7.21312e+06 1307.06 6.95098e+06 838954 1.17692e+06 8.17288e+06 3.14298e+07
54242 20221115.17 0.768186 17555.9 47612.1 14068.4 4501.62 3624.91 6317.26 8.21863e+07 3320.22 15931.3 1.50774e+07 24529.5 5581.5 1.53396e+07 1558.66 7.99955e+06 1282.82 7.21312e+06 1286.83 6.95098e+06 827014 1.17855e+06 8.12247e+06 3.2029e+07
54265 20221115.24 0.768362 17240.8 45526.3 12505.9 4390.79 3643.06 6315.12 8.24484e+07 3312.91 15828.8 1.58639e+07 26523.2 5628.96 1.50774e+07 1560.78 7.99955e+06 1282.09 7.47526e+06 1290.26 6.95098e+06 837629 1.18054e+06 8.16867e+06 3.15383e+07
54279 20221115.29 0.813007 17301.1 43647.4 12248.2 4650.32 3617.05 6336.12 8.21863e+07 3327.01 15969.6 1.50774e+07 27864.6 5857.95 1.50774e+07 1558.42 7.99955e+06 1292.86 7.47526e+06 1301.87 6.95098e+06 841504 1.18227e+06 8.15501e+06 3.11185e+07
54301 20221115.34 0.784383 17465.7 47965.7 12468.5 4659.93 3644.94 6248.11 8.21863e+07 3473.83 15906.8 1.50774e+07 24972.5 5801.45 1.50774e+07 1554.74 7.99955e+06 1277.21 7.21312e+06 1298.96 6.95098e+06 829779 1.17918e+06 8.15322e+06 3.06996e+07
54312 20221115.38 0.760219 17603.2 48071.3 12445.5 4535.05 3664.65 6329.59 8.29727e+07 3417.72 15997.9 1.50774e+07 22644.4 5816.31 1.50774e+07 1571.17 7.99955e+06 1284.39 7.47526e+06 1296.86 6.95098e+06 834696 1.17624e+06 8.15209e+06 3.06964e+07
54320 20221116.2 0.73629 17079.3 45748.5 12665.4 4581.7 3693.92 6346.84 8.24484e+07 3440.77 15948.8 1.50774e+07 26358 5640.68 1.45532e+07 1571.22 7.99955e+06 1290.87 7.47526e+06 1306.9 6.95098e+06 830202 1.18442e+06 8.17004e+06 3.07984e+07
54346 20221116.13 0.757808 17507.2 43588.6 12416.2 4541.76 3540.71 6293.31 8.24484e+07 3435.12 15682.8 1.50774e+07 25172.1 5765.59 1.50774e+07 1547.8 7.99955e+06 1278.43 7.73741e+06 1274.23 6.95098e+06 830766 1.18245e+06 8.17242e+06 3.1604e+07
54373 20221116.21 0.794069 17629.9 43644.5 12496.5 4488.01 3677.13 6280.35 8.24484e+07 3491.35 16067 1.50774e+07 24907.4 5935.03 1.48153e+07 1561.63 7.99955e+06 1285.84 7.21312e+06 1284.05 6.95098e+06 832849 1.18032e+06 8.15416e+06 3.08741e+07
54415 20221116.32 0.774201 17201.1 46001.9 12448 4542.79 3670.08 6290.81 8.24484e+07 3335.71 16036 1.53396e+07 28306.9 5851.6 1.50774e+07 1570.04 7.99955e+06 1283.18 7.21312e+06 1307.36 7.21312e+06 841574 1.18371e+06 8.15316e+06 3.07198e+07
54431 20221116.37 0.758055 17222.2 47887.3 12509.1 4683.51 3628.06 6335.86 8.27106e+07 3442.08 16037.6 1.56017e+07 22721.6 5785.4 1.45532e+07 1569.25 7.99955e+06 1287.15 7.47526e+06 1302.29 7.21312e+06 825986 1.17562e+06 8.14738e+06 3.09025e+07
54491 20221116.53 0.762513 16827.5 48004.1 12436.3 4468.65 3633.07 6289.35 8.24484e+07 3416.61 15766 1.53396e+07 32617.3 5770.86 1.53396e+07 1561.94 7.99955e+06 1280.9 7.21312e+06 1292.72 6.95098e+06 838592 1.1807e+06 8.15348e+06 3.09571e+07
54578 20221116.76 0.779431 17661.5 48265.2 12488.4 4533.85 3636.43 6244.97 8.24484e+07 3511.1 15919 1.50774e+07 21836.1 5852.85 1.53396e+07 1555.09 7.99955e+06 1277.04 7.73741e+06 1284.29 6.95098e+06 834709 1.17526e+06 8.15478e+06 3.0784e+07
54593 20221116.81 0.795509 17657.5 43562.8 12562.2 4423.56 3373.65 5654.64 8.29727e+07 3346.12 15778.9 1.50774e+07 23982.7 5554.46 1.50774e+07 1543.18 7.99955e+06 1270.51 7.21312e+06 1273.78 6.95098e+06 836854 1.17832e+06 8.15459e+06 3.08406e+07
54600 20221116.83 0.773857 17658.1 47915 12299.3 4558.65 3628.94 5673.28 8.21863e+07 3348.46 15711.8 1.50774e+07 22622.8 5566.98 1.50774e+07 1545.15 7.99955e+06 1257.82 7.73741e+06 1286.91 6.95098e+06 818313 1.17567e+06 8.16499e+06 3.07332e+07
54610 20221117.2 0.808576 17252.3 45666.1 12534.4 4654.76 3650.47 6300.52 8.27106e+07 3444.46 15971.4 1.50774e+07 22384.6 5838.6 1.50774e+07 1563.83 7.99955e+06 1289.22 7.73741e+06 1304.59 6.95098e+06 840263 1.18352e+06 8.15468e+06 3.08257e+07
54840 20221117.54 0.754537 17204.7 44071 12334 4572.05 3635.68 6328.89 8.24484e+07 3506.41 16055.7 1.50774e+07 23659.8 5655.16 1.48153e+07 1563.51 7.99955e+06 1293.82 7.99955e+06 1301.31 6.95098e+06 829313 1.17836e+06 8.15563e+06 3.0909e+07
54891 20221117.72 0.784931 17223 43706.2 13929.7 4628.37 3545.47 6298.63 8.21863e+07 3470.93 15945 1.50774e+07 25462 5711.26 1.48153e+07 1545.87 7.99955e+06 1274.42 7.73741e+06 1289.31 6.95098e+06 834862 1.17851e+06 8.17382e+06 3.08862e+07
54901 20221118.1 0.763921 17099.4 46007 12416.2 4502.74 3618.87 6354.21 8.27106e+07 3390.27 16027.1 1.50774e+07 27487.2 5837.83 1.53396e+07 1563.19 7.99955e+06 1287.14 7.21312e+06 1307.2 6.95098e+06 835740 1.17711e+06 8.15494e+06 3.0966e+07
54937 20221118.18 0.76303 17464.2 43714 12804.5 4636.78 3638.76 6244.73 8.19242e+07 3406.27 15939.1 1.50774e+07 22102 5643.19 1.48153e+07 1543.14 7.99955e+06 1282.57 7.21312e+06 1299.16 6.95098e+06 831458 1.18105e+06 8.15452e+06 3.0809e+07

snp_artefacts_decorator

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
54872 20221117.64 0.785849 17333.8 45544.5 12425.3 4508.5 3500.59 3312.65 24718.3 6344.72 8.24484e+07 15929.9 1.50774e+07 5811.78 1.50774e+07 1575.66 7.99955e+06 1298.86 7.21312e+06 1309.28 7.21312e+06 830213 1.18275e+06 8.15485e+06 3.08146e+07
54896 20221117.73 0.779672 17107 45689.3 12453.1 4522.73 3546.85 3415.79 23380.8 6330.96 8.24484e+07 15918.9 1.50774e+07 5816.7 1.50774e+07 1557.59 7.99955e+06 1284.48 7.73741e+06 1304.64 6.95098e+06 835234 1.18449e+06 8.15355e+06 3.1028e+07
54930 20221118.15 0.788359 17271.8 47959 12684.3 4662.73 3516.91 3405.09 26182.6 6338.66 8.21863e+07 16002.8 1.50774e+07 5802.08 1.50774e+07 1568.5 7.99955e+06 1291.38 7.21312e+06 1306.07 6.95098e+06 836683 1.18148e+06 8.14768e+06 3.06665e+07
54946 20221118.21 0.777746 17269.2 45692.8 12576.3 4422.43 3678.18 3541.3 22303.4 6317.51 8.21863e+07 15696.1 1.56017e+07 5578.19 1.50774e+07 1544.43 7.99955e+06 1280.26 7.21312e+06 1295.91 7.21312e+06 827251 1.17175e+06 8.15413e+06 3.08601e+07

images

@jumaffre jumaffre merged commit d88c76a into microsoft:main Nov 18, 2022
@github-actions
Copy link

💔 All backports failed

Status Branch Result
❌ release/3.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 4569

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jumaffre jumaffre mentioned this pull request Nov 18, 2022
Merged
jumaffre added a commit to jumaffre/CCF that referenced this pull request Nov 18, 2022
@jumaffre
Decorate and identify SNP libraries (microsoft#4569)
6ebcedc 
(cherry picked from commit d88c76a)

# Conflicts:
#	.daily_canary
#	.snpcc_canary
#	tests/infra/remote.py
@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Nov 18, 2022
jumaffre added a commit that referenced this pull request Nov 18, 2022
@jumaffre
[release/3.x] Cherry pick: Decorate and identify SNP libraries (#4569) (
5901a86 
#4590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
3.x-todo PRs which should be backported to 3.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release and packaging for SEV-SNP
3 participants
@jumaffre @achamayou @DomAyre