Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEV-SNP ACI: Retrieve attestation report endorsements from environment #4940

Merged
merged 26 commits into from
Feb 7, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Feb 1, 2023

Part of #4637

Now that the attestation report endorsements are also exposed to ACI via the UVM_HOST_AMD_CERTIFICATE environment variable, we use the value of it by default, if it's present, instead of fetching the endorsements from the Azure or AMD remote server. Even though we don't expect upcoming CCF deployments to fetch these endorsements remotely, we keep the feature in so that CCF can still be deployed on non-ACI SEV-SNP.

@jumaffre jumaffre requested a review from a team February 1, 2023 17:16
@ghost
Copy link

ghost commented Feb 2, 2023

snp_quote_endorsement_envvar@63706 aka 20230207.48 vs main ewma over 20 builds from 63081 to 63690

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
63081 20230203.5 0.795023 17131.8 6349.48 8.24484e+07 43980.8 47350.7 12550 13529.8 15134.4 1.53396e+07 15587.5 8.2617e+06 4388.03 5525.12 1.45532e+07 3550.62 5630.6 4.59168e+06 3319.38 1544.35 7.73741e+06 24649.8 1270.98 7.21312e+06 1265.61 6.95098e+06 841203 1.18097e+06 8.15465e+06 3.14062e+07
63141 20230203.22 0.82072 17350.3 6287.61 8.21863e+07 41903.1 46724.4 12580.3 13360.6 15301.3 1.53396e+07 15571.4 8.2617e+06 4192.74 5499.18 1.4291e+07 3452.2 5603.1 4.59168e+06 3324.24 1541.11 7.73741e+06 24879.3 1266.78 7.21312e+06 1270.65 6.95098e+06 834673 1.17634e+06 8.17183e+06 3.21734e+07
63191 20230203.34 0.794791 17078.6 6253.98 8.1662e+07 43775.2 45923.2 12938.2 13702.8 15191.6 1.53396e+07 15514.1 8.2617e+06 4506.97 5504.94 1.4291e+07 3551.93 5621.6 4.59168e+06 3295.22 1529.72 7.73741e+06 23998.3 1253.16 7.47526e+06 1264.96 6.95098e+06 833138 1.17799e+06 8.17242e+06 3.14029e+07
63229 20230203.42 0.793881 17186 6284.6 8.19242e+07 45594.9 47202.5 12620.5 12946.2 15158.6 1.53396e+07 15614.5 8.2617e+06 4628.1 5488.22 1.4291e+07 3651.85 5627.7 4.59168e+06 3322.12 1536.93 7.73741e+06 24808.9 1268.17 7.21312e+06 1270.44 6.95098e+06 832035 1.17932e+06 8.15371e+06 3.07457e+07
63273 20230203.54 0.798364 17200.6 6202.89 8.21863e+07 45782.7 47712.9 12329.4 13008.5 15172.9 1.50774e+07 15545.6 8.2617e+06 4425.63 5514.29 1.45532e+07 3519.27 5541 4.59168e+06 3273.88 1521.77 7.73741e+06 23110.1 1254.45 7.21312e+06 1262.62 6.95098e+06 826543 1.17451e+06 8.15566e+06 3.10614e+07
63296 20230203.60 0.795783 17108 5686.27 8.3497e+07 45791.8 44741.5 12466.6 13770.5 14968.6 1.53396e+07 15441.6 8.2617e+06 4428.89 5512.47 1.4291e+07 3663.65 5597.6 4.59168e+06 3321.75 1519.82 7.73741e+06 25397.6 1249.76 6.95098e+06 1244.97 6.95098e+06 842378 1.1794e+06 8.16786e+06 3.08448e+07
63317 20230204.3 0.790369 17171.5 6301.04 8.21863e+07 41684.3 46667.9 12354.1 13436 15075.2 1.50774e+07 15587.8 8.2617e+06 4617.99 5549.48 1.4291e+07 3519.18 5666.9 4.59168e+06 3320.78 1546.4 7.73741e+06 26287 1272.38 7.21312e+06 1267.03 6.95098e+06 835091 1.17543e+06 8.15322e+06 3.08545e+07
63334 20230206.3 0.806881 17294.9 6282.84 8.19242e+07 41876.1 46721.1 12495.9 13501.7 15110.2 1.50774e+07 15588.6 8.2617e+06 4630.32 5507.29 1.4291e+07 3543.31 5630.8 4.59168e+06 3310.02 1541.81 7.73741e+06 28320.3 1271.12 7.21312e+06 1273.2 6.95098e+06 834589 1.18212e+06 8.154e+06 3.08058e+07
63343 20230206.5 0.781462 17075.3 6311.15 8.19242e+07 41812.7 47754.4 12767 13788 15265.2 1.50774e+07 15526.5 8.2617e+06 4445.42 5493.79 1.45532e+07 3617.76 5599.2 4.59168e+06 3332.08 1532.76 7.73741e+06 21834.4 1269.84 7.21312e+06 1268.87 6.95098e+06 795391 1.17459e+06 8.15287e+06 3.09557e+07
63367 20230206.10 0.801304 17064.2 6285.7 8.19242e+07 45669.5 47270.6 12892.1 13349.2 15256.7 1.53396e+07 15551.1 7.99955e+06 4593.93 5532.97 1.48153e+07 3545.8 5617.4 4.59168e+06 3293.34 1537.86 7.73741e+06 24522.5 1270.93 7.21312e+06 1261.69 6.95098e+06 839322 1.17661e+06 8.14703e+06 3.08039e+07
63374 20230206.13 0.803173 17074.2 6251.57 8.21863e+07 41699.8 47480.4 11456.4 12769.9 15279 1.53396e+07 15527.3 8.2617e+06 4331.63 5507.43 1.4291e+07 3524.35 5634.8 4.59168e+06 3167.52 1533.81 7.73741e+06 26367.1 1270.85 7.47526e+06 1271.61 6.95098e+06 830139 1.17498e+06 8.15576e+06 3.08857e+07
63385 20230206.16 0.856939 17119.3 6314.35 8.19242e+07 43654.8 47475.2 12785.3 12628.5 15024.3 1.50774e+07 15527.3 8.2617e+06 4448.16 5516.97 1.4291e+07 3556.8 5631.7 4.59168e+06 3316.29 1538.52 7.73741e+06 24964.9 1271.24 7.47526e+06 1273.4 6.95098e+06 810700 1.17052e+06 8.15485e+06 3.08026e+07
63419 20230206.23 0.804012 17021.4 6331.17 8.19242e+07 43763.7 47238.2 11554.4 13728.9 15105.2 1.50774e+07 15522.5 8.2617e+06 4657.27 5513.02 1.40289e+07 3691.29 5627.2 4.59168e+06 3478.77 1543.72 7.73741e+06 27282.5 1270.45 7.21312e+06 1270.98 6.95098e+06 819514 1.17678e+06 8.15313e+06 3.08801e+07
63453 20230206.32 0.805779 17123 5607.31 8.24484e+07 42004.7 47908.3 12825.7 12760.1 15023.5 1.53396e+07 15326.7 8.2617e+06 4392.36 5524.52 1.48153e+07 3662.11 5536.5 4.59168e+06 3480.86 1521.95 7.73741e+06 29165.8 1257.45 7.21312e+06 1251.35 6.95098e+06 839672 1.17946e+06 8.15524e+06 3.07544e+07
63522 20230207.3 0.794561 17169.1 6317.95 8.21863e+07 42042.5 47438.1 12741.9 13404.5 15101.7 1.50774e+07 15566.9 8.2617e+06 4522.78 5507.87 1.48153e+07 3669.57 5633.9 4.59168e+06 3467.46 1540.57 7.73741e+06 23288.9 1269.45 7.21312e+06 1267.42 6.95098e+06 832347 1.17941e+06 8.15436e+06 3.07217e+07
63546 20230207.9 0.799724 17181.6 6369.51 8.24484e+07 40186.6 45789.6 11473.1 13679 15350.4 1.50774e+07 15596.9 8.2617e+06 4508.19 5521.42 1.4291e+07 3472.53 5624.4 4.59168e+06 3348.17 1540.98 7.73741e+06 28751.2 1269.72 7.21312e+06 1270.21 6.95098e+06 834870 1.18145e+06 8.13476e+06 3.07374e+07
63571 20230207.15 0.768711 17243.9 6218.16 8.21863e+07 42145.1 47832 12845.4 13589 15228.2 1.53396e+07 15538.1 8.2617e+06 4494.96 5482.67 1.4291e+07 3516.84 5606.7 4.59168e+06 3309.13 1536.76 7.99955e+06 24034.4 1265.58 7.21312e+06 1248.69 6.95098e+06 821652 1.17955e+06 8.17392e+06 3.07979e+07
63594 20230207.22 0.775456 17080.3 6222.8 8.21863e+07 41799.8 47576.2 12867 13436.5 15032.4 1.53396e+07 15512.2 8.2617e+06 4396.26 5550.82 1.45532e+07 3575.19 5573.9 4.59168e+06 3416.42 1520.87 7.73741e+06 21670.2 1266.61 7.21312e+06 1261.34 6.95098e+06 832117 1.177e+06 8.12979e+06 3.08397e+07
63661 20230207.38 0.801481 17118.9 6292.16 8.19242e+07 43790.9 47843.9 12719.7 12516.8 15298.5 1.50774e+07 15546.8 8.2617e+06 4450.94 5499.73 1.48153e+07 3552.52 5581.5 4.59168e+06 3335.97 1539.89 7.73741e+06 22276.5 1249.98 7.21312e+06 1261.91 6.95098e+06 835801 1.17635e+06 8.15511e+06 3.09539e+07
63690 20230207.45 0.821862 17094.4 6305.95 8.21863e+07 43589.8 47792.9 12524.4 13635.3 14981.9 1.50774e+07 15391.5 8.2617e+06 4465.36 5504.1 1.4291e+07 3618.65 5597 4.59168e+06 3440.73 1522.26 7.73741e+06 20641.2 1256.67 7.21312e+06 1262.14 6.95098e+06 826351 1.17578e+06 8.17131e+06 3.07498e+07

snp_quote_endorsement_envvar

build_id build_number Commit latency factor tpcc_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
63241 20230203.45 0.787625 17231.2 6257.32 8.21863e+07 43768.9 45624.6 12837.7 12932.1 4641.3 14942.3 1.56017e+07 15491.7 8.2617e+06 3514.18 5465.18 1.4291e+07 3303.63 5542.6 4.59168e+06 1524.59 7.73741e+06 21946.1 1254.14 7.21312e+06 1261.01 6.95098e+06 832118 1.17717e+06 8.10482e+06 3.07933e+07
63467 20230206.35 0.784062 17232.5 5638.65 8.24484e+07 43734.6 46163.1 12661.9 12388.4 4357.36 14895.6 1.50774e+07 15426.4 8.2617e+06 3432.82 5456.35 1.45532e+07 3284.6 5538.8 4.59168e+06 1520.28 7.73741e+06 23764.2 1254.43 7.47526e+06 1245.25 6.95098e+06 835608 1.17961e+06 8.15199e+06 3.07873e+07
63612 20230207.26 0.818455 17183.4 6286.94 8.24484e+07 41774.4 45668.8 12651.1 13217.6 4475.84 15030.6 1.50774e+07 15504.1 8.2617e+06 3459.82 5506.76 1.45532e+07 3332.19 5564 4.59168e+06 1532.83 7.73741e+06 27376.2 1265.69 7.21312e+06 1261.76 6.95098e+06 833004 1.18271e+06 8.15475e+06 3.08796e+07
63674 20230207.41 0.791107 17231.4 6316.93 8.19242e+07 39998.2 43057.6 12574.6 12619.9 4545.76 15160.8 1.50774e+07 15604.3 8.2617e+06 3520.98 5550.39 1.45532e+07 3292.64 5627.7 4.59168e+06 1543.95 7.73741e+06 20381.8 1270.82 7.21312e+06 1268.21 6.95098e+06 837371 1.17936e+06 8.15154e+06 3.08411e+07
63706 20230207.48 0.775191 16971 6319.06 8.21863e+07 41960.6 47307.5 12711.5 12644.1 4454.16 15087.1 1.53396e+07 15457.9 8.2617e+06 3441.3 5522.43 1.45532e+07 3323.69 5606.6 4.59168e+06 1543.6 7.73741e+06 20770.2 1267.86 7.47526e+06 1273.07 6.95098e+06 840641 1.18173e+06 8.15628e+06 3.25405e+07

images

CMakeLists.txt Show resolved Hide resolved
src/node/node_state.h Show resolved Hide resolved
@jumaffre
Copy link
Contributor Author

jumaffre commented Feb 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@jumaffre jumaffre merged commit 7801b5d into microsoft:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants