Add support for host process stdio. #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application launches a process on the host, it now has the option to attach a bytestring which will be passed on the process' standard input. Additionally, the standard output and error of the process are captured and printed in CCF's log. This makes it a lot easier to monitor and diagnose issues in production.
plietar
changed the title
|
plietar/host-proc-stdio@66100 aka 20230228.39 vs main ewma over 20 builds from 65395 to 66092 Click to see tablemain
plietar/host-proc-stdio
|
achamayou
reviewed
Feb 23, 2023
achamayou
reviewed
Feb 23, 2023
|
I'm not sure if it really needs be marked as such, since it isn't particularly long to run from what I can tell, but I don't really know what the criteria is. |
plietar
added
auto-backport
if it's less than 30 seconds, please remove that condition. |
If writing as two separate commands, the Python script could read the partial file, leading to a test failure.
Test was marked as LONG_TESTS, meaning it only ran on the Daily CI. It seems to run pretty fast (<10 seconds), so this seems unnecessary.
|
It's about 10 seconds, so I've changed it |
letmaik
reviewed
Feb 24, 2023
plietar
force-pushed
the
plietar/host-proc-stdio
branch
from
613dfc4 to
e0f5b1e
Compare
letmaik
approved these changes
Feb 27, 2023
|
@plietar please add an entry to the changelog if you are going to backport this. Also note the auto-backporting is currently broken due to a restriction put in place on the org that forbids PR creation from GH actions unfortunately. You will need to run the backport CLI. |
achamayou
approved these changes
Feb 28, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
plietar
added a commit
to plietar/CCF
that referenced
this pull request
Mar 1, 2023
(cherry picked from commit 9461128) # ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # .daily_canary # CHANGELOG.md
wintersteiger
pushed a commit
to wintersteiger/CCF
that referenced
this pull request
Mar 1, 2023
plietar
added a commit
that referenced
this pull request
Mar 1, 2023
shokouedamsr
added
the
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application launches a process on the host, it now has the option to attach a bytestring which will be passed on the process' standard input.
Additionally, the standard output and error of the process are captured and printed in CCF's log. This makes it a lot easier to monitor and diagnose issues in production.