Historical queries: Do not fetch entries until an early-enough secret has been fetched #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
added
2.x-todo
|
historical_refactor_fixes@65906 aka 20230227.22 vs main ewma over 20 builds from 65333 to 65885 Click to see tablemain
historical_refactor_fixes
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
achamayou
approved these changes
Feb 27, 2023
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Feb 27, 2023
… has been fetched (microsoft#5058)
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Feb 27, 2023
… has been fetched (microsoft#5058)
This was referenced Feb 27, 2023
eddyashton
added
the
backported
achamayou
pushed a commit
that referenced
this pull request
Feb 27, 2023
achamayou
pushed a commit
that referenced
this pull request
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5042.
The changes in #5026 meant that historical queries would result in fetches from the host immediately, even if a sufficiently-early secret was not yet known in-enclave. That results in a lot of wasted work - the host fetches and transmits many ledger entries, the enclave discards them as unreadable, repeats periodically - which should eventually resolve, but in instrumented builds exceeds our expected timeouts. This change restores the previous behaviour; entries are only fetched from the host once we have an early-enough secret for them.
There's a few minor performance tweaks associated with this - avoiding double-lookup of the same seqno, and avoiding pessimal sharding of request ranges when some secrets are known.
I'd like to validate this with a few runs through the Daily, and then I will manually backport by including it in #5033 and #5034.
EDIT - Daily looks happy.