Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEV-SNP: support for multiple measurement types on same node #5063

Merged
merged 29 commits into from
Feb 28, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Feb 27, 2023

Part of #4072

Previously, a node built for a specific platform (i.e. SNP or SGX) would consider all attestation measurements as for that specific platform, preventing code updates from one platform to the other.

A single node can now support multiple types of measurements, with as much as possible appropriate type safety, as measurements are of different sizes on different platforms.

Notes:

  • CodeDigest has been renamed to PlatformAttestationMeasurement.
  • code_id, code_digest, etc. have been renamed to measurement in most of the C++ code, with the exception of mrenclave in the GET /node/quotes endpoint, and code_digest in the nodes table.

Next: Remove SNP-specific endpoints, now superseded by generic KV governance endpoints.

@ghost
Copy link

ghost commented Feb 28, 2023

measurement_size_cross_platform@66077 aka 20230228.31 vs main ewma over 20 builds from 65388 to 66071

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
65388 20230220.67 0.792798 17112.4 44008.9 6329.01 8.21863e+07 48921 12452.3 13870.8 4488.31 15755.8 1.50774e+07 16141.1 7.99955e+06 3795.98 5793.8 1.4291e+07 3319.49 5728.7 4.59168e+06 1537.13 7.73741e+06 48473.8 1339.93 7.21312e+06 1261.9 6.95098e+06 825594 1.1741e+06 8.17395e+06 3.13155e+07
65395 20230220.69 0.787055 17201.2 43790.5 6303.67 8.1662e+07 49701.8 12379.1 13052.3 4630.77 15805.6 1.50774e+07 16136.2 7.99955e+06 3804.63 5503.63 1.45532e+07 3441.09 5671.3 4.06739e+06 1528.03 7.73741e+06 45845.4 1339.44 7.21312e+06 1247.67 6.95098e+06 831800 1.17776e+06 8.15576e+06 3.11488e+07
65405 20230221.3 0.817252 17147.1 43675.1 6348.16 8.1662e+07 48039.3 13048.9 13008.5 4413.92 15855.9 1.50774e+07 16148.2 7.99955e+06 3831.64 5511.03 1.45532e+07 3318.21 5672 4.06739e+06 1529.87 7.47526e+06 48277.8 1342.99 7.21312e+06 1265.42 6.95098e+06 835213 1.17709e+06 8.15397e+06 3.20631e+07
65441 20230221.17 0.80644 17170.1 45602.1 5674.58 8.24484e+07 49340.8 12330.1 13749.7 4662.92 15754.4 1.50774e+07 16062.6 7.99955e+06 3836.97 5542.41 1.48153e+07 3325.78 5669.8 4.06739e+06 1522.74 7.73741e+06 44387.9 1337.52 7.21312e+06 1241.45 6.95098e+06 836782 1.17219e+06 8.13651e+06 3.07961e+07
65456 20230222.2 0.787913 17248.7 45771.5 6308.62 8.21863e+07 48055.9 12465.5 13974.3 4548.91 15730.7 1.50774e+07 15444.5 7.99955e+06 3893.18 5480.3 1.48153e+07 3348.55 5664.5 4.06739e+06 1533.77 7.73741e+06 46506.4 1341.05 7.21312e+06 1254.32 6.95098e+06 825679 1.17963e+06 8.14933e+06 3.08109e+07
65467 20230222.8 0.814029 16922.3 43920.7 6314.31 8.24484e+07 49814.5 12640.3 13756.5 4550.95 15550.4 1.50774e+07 16096.8 7.99955e+06 3754.76 5596.93 1.48153e+07 3419.78 5669.3 4.06739e+06 1528.11 7.99955e+06 47792.7 1336.69 7.99955e+06 1249.71 6.95098e+06 817630 1.17699e+06 8.17395e+06 3.26432e+07
65492 20230222.16 0.792438 17326.4 45738.7 5572.44 8.24484e+07 48222.5 12275.5 13721.5 4400.76 15412.2 1.50774e+07 16032.5 7.99955e+06 3681.37 5361.95 1.50774e+07 3290.5 5633.5 4.06739e+06 1537.4 7.99955e+06 47353.8 1319.06 7.73741e+06 1253.28 6.95098e+06 832455 1.18002e+06 8.17297e+06 3.07291e+07
65534 20230223.2 0.795707 17129.5 45774.3 6259.09 8.19242e+07 46241.5 12759.4 12968 4238.13 15727.7 1.50774e+07 16064.3 7.99955e+06 3772.11 5552.7 1.48153e+07 3431.46 5666.2 4.06739e+06 1532.9 7.73741e+06 44436.5 1339.44 7.73741e+06 1248.39 6.95098e+06 834169 1.17443e+06 8.17164e+06 3.11948e+07
65696 20230224.3 0.800575 17207.2 45541.5 6272.76 8.21863e+07 47574.9 12405.1 13902 4397.4 15749.8 1.50774e+07 16111.6 7.99955e+06 3826.36 5534.75 1.48153e+07 3400.41 5683 4.06739e+06 1528.4 7.73741e+06 44456.5 1341.63 7.21312e+06 1252.52 6.95098e+06 834055 1.18116e+06 8.1567e+06 3.08643e+07
65705 20230224.6 0.78948 17268.8 43549.7 6241.22 8.24484e+07 47509.5 12856.2 13058.9 4410.34 15498.5 1.53396e+07 16064.6 7.99955e+06 3800.5 5503.39 1.48153e+07 3306.36 5677.4 4.06739e+06 1540.18 7.73741e+06 48308.6 1339.13 7.21312e+06 1263.03 6.95098e+06 833135 1.17628e+06 8.13554e+06 3.07438e+07
65748 20230224.16 0.783917 17175.6 43876.7 6234 8.21863e+07 48773.6 12408.3 13732.1 4638.57 15783 1.50774e+07 16132.6 7.99955e+06 3844.13 5525.08 1.45532e+07 3343.87 5703.2 4.06739e+06 1541.66 7.73741e+06 43140.2 1342.66 7.21312e+06 1261.05 6.95098e+06 838176 1.17692e+06 8.14914e+06 3.11625e+07
65835 20230227.2 0.803495 17122.6 43856.6 6323.57 8.1662e+07 47985.6 12298.6 12642.2 4505.39 15698.9 1.50774e+07 16124.5 7.99955e+06 3736.13 5482.34 1.45532e+07 3320.5 5673.2 4.06739e+06 1541.99 7.73741e+06 44280.5 1338.53 7.21312e+06 1254.22 6.95098e+06 841984 1.17778e+06 8.15397e+06 3.08049e+07
65837 20230227.4 0.80932 17317.2 43644.7 6274.57 8.21863e+07 48657.8 12696.7 13023.4 4487.02 15811.2 1.50774e+07 16164.9 7.99955e+06 3801.1 5506.78 1.48153e+07 3329.78 5671.4 4.59168e+06 1536.88 7.73741e+06 47709.5 1343.79 7.21312e+06 1249.28 7.21312e+06 830710 1.17551e+06 8.17418e+06 3.08127e+07
65847 20230227.7 0.798798 17186.7 45859.3 6273.56 8.24484e+07 47941.4 12897.6 13185.3 4348.5 15827.4 1.50774e+07 16108.4 7.99955e+06 3692.98 5478.28 1.48153e+07 3437.49 5675.2 4.06739e+06 1534.74 7.73741e+06 45788.5 1333.8 7.21312e+06 1251.3 6.95098e+06 832584 1.1833e+06 8.15436e+06 3.18919e+07
65877 20230227.15 0.79398 17349.5 43746.6 5664.91 8.24484e+07 47761.4 12366.4 13180.4 4366.45 15732.6 1.50774e+07 16079 7.99955e+06 3665.95 5530.31 1.45532e+07 3325.45 5674.3 4.06739e+06 1538.77 7.73741e+06 44624.8 1344.3 7.73741e+06 1250.19 6.95098e+06 836973 1.18009e+06 8.15556e+06 3.07069e+07
65885 20230227.17 0.797773 17242.7 45737.2 5652.56 8.27106e+07 47533.3 12865.5 13860.4 4380.68 15799.3 1.50774e+07 16094.7 7.99955e+06 3830.6 5507.5 1.48153e+07 3324.1 5639.8 4.32954e+06 1526.82 7.73741e+06 44211.7 1328.99 7.73741e+06 1242 6.95098e+06 835814 1.17601e+06 8.15193e+06 3.08035e+07
65937 20230227.30 0.784716 17181.1 45718.6 6278.88 8.19242e+07 48568 12842.8 13304.8 4331.77 15823.1 1.50774e+07 16139.9 7.99955e+06 3715.11 5499.37 1.4291e+07 3294.52 5675.5 4.06739e+06 1542.13 7.73741e+06 48387.5 1336.15 7.47526e+06 1257.2 6.95098e+06 836085 1.17634e+06 8.14794e+06 3.10614e+07
65959 20230227.36 0.802885 17164.4 43586.7 6224.99 8.24484e+07 49062.4 12863 13760.4 4338.4 15775 1.50774e+07 16045.3 7.99955e+06 3831.55 5492.28 1.45532e+07 3344.51 5613 4.06739e+06 1515.56 7.73741e+06 43900.1 1323.89 7.47526e+06 1237.88 7.21312e+06 833464 1.17411e+06 8.15468e+06 3.07364e+07
65995 20230228.2 0.784824 16945.8 43743.6 6288 8.21863e+07 46799.4 12848.9 13773.8 4343.54 15786.6 1.50774e+07 16143 7.99955e+06 3822.45 5521.67 1.50774e+07 3311.98 5677.9 4.06739e+06 1532.31 7.73741e+06 44237.9 1343.93 7.73741e+06 1256.92 6.95098e+06 839395 1.18029e+06 8.14849e+06 3.0649e+07
66071 20230228.30 0.802223 17135.2 45675.4 5655.46 8.24484e+07 39401.2 12916.7 12979.4 4361.08 15490.5 1.50774e+07 16017.8 7.99955e+06 3826.06 5499.37 1.48153e+07 3321.86 5606 4.06739e+06 1519.61 7.73741e+06 45149.3 1337.08 7.21312e+06 1239.01 6.95098e+06 840187 1.18113e+06 8.15472e+06 3.09249e+07

measurement_size_cross_platform

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem hist_sgx_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
66022 20230228.12 0.819837 17203.2 45648.2 48507.5 6287.75 8.21863e+07 12523.3 13090.6 4422.68 3673.43 15795.4 1.50774e+07 16080 7.99955e+06 3278.18 5525.33 1.48153e+07 5645.4 4.06739e+06 45146.8 1519.85 7.73741e+06 1339.44 7.47526e+06 1259 6.95098e+06 843745 1.18066e+06 8.15566e+06 3.06266e+07
66032 20230228.15 0.802978 17336.7 43433.7 45808.1 6308.94 8.21863e+07 12831.5 13074.3 4564.11 3809.19 15747.3 1.50774e+07 16105.9 7.99955e+06 3297.66 5542.34 1.45532e+07 5640.1 4.06739e+06 48300.9 1518.19 7.73741e+06 1335.41 7.47526e+06 1258.37 6.95098e+06 830052 1.17428e+06 8.15296e+06 3.09923e+07
66042 20230228.19 0.780715 17151 45508 48195.8 6244.79 8.1662e+07 12391.5 12808.7 4354.77 3802.89 15840 1.50774e+07 16178.9 7.99955e+06 3280.58 5522.87 1.48153e+07 5674.5 4.06739e+06 46843.5 1543.36 7.73741e+06 1340.16 7.21312e+06 1251.31 6.95098e+06 834322 1.17942e+06 8.13638e+06 3.12619e+07
66077 20230228.31 0.801445 17130.4 45778.9 46828.1 6254.17 8.21863e+07 12894.1 13824.4 4390.34 3827.49 15718.5 1.53396e+07 16143.8 7.99955e+06 3304.58 5531.35 1.45532e+07 5634.8 4.06739e+06 44742.5 1518.3 7.73741e+06 1338.24 7.21312e+06 1238.23 6.95098e+06 829650 1.17778e+06 8.11266e+06 3.08304e+07

images

@jumaffre jumaffre marked this pull request as ready for review February 28, 2023 13:34
@jumaffre jumaffre requested a review from a team February 28, 2023 13:34
@achamayou achamayou merged commit 23dfa31 into microsoft:main Feb 28, 2023
wintersteiger pushed a commit to wintersteiger/CCF that referenced this pull request Mar 1, 2023
wintersteiger pushed a commit to wintersteiger/CCF that referenced this pull request Mar 1, 2023
wintersteiger pushed a commit to wintersteiger/CCF that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants