-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEV-SNP: support for multiple measurement types on same node #5063
Merged
achamayou
merged 29 commits into
microsoft:main
from
jumaffre:measurement_size_cross_platform
Feb 28, 2023
Merged
SEV-SNP: support for multiple measurement types on same node #5063
achamayou
merged 29 commits into
microsoft:main
from
jumaffre:measurement_size_cross_platform
Feb 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/CCF into measurement_size_cross_platform
measurement_size_cross_platform@66077 aka 20230228.31 vs main ewma over 20 builds from 65388 to 66071 Click to see tablemain
measurement_size_cross_platform
|
eddyashton
reviewed
Feb 28, 2023
eddyashton
approved these changes
Feb 28, 2023
achamayou
approved these changes
Feb 28, 2023
wintersteiger
pushed a commit
to wintersteiger/CCF
that referenced
this pull request
Mar 1, 2023
wintersteiger
pushed a commit
to wintersteiger/CCF
that referenced
this pull request
Mar 1, 2023
wintersteiger
pushed a commit
to wintersteiger/CCF
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4072
Previously, a node built for a specific platform (i.e. SNP or SGX) would consider all attestation measurements as for that specific platform, preventing code updates from one platform to the other.
A single node can now support multiple types of measurements, with as much as possible appropriate type safety, as measurements are of different sizes on different platforms.
Notes:
CodeDigest
has been renamed toPlatformAttestationMeasurement
.code_id
,code_digest
, etc. have been renamed tomeasurement
in most of the C++ code, with the exception ofmrenclave
in theGET /node/quotes
endpoint, andcode_digest
in the nodes table.Next: Remove SNP-specific endpoints, now superseded by generic KV governance endpoints.