Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move side-effects out of common.cmake and into CMakeLists.txt #5287

Merged
merged 5 commits into from
May 23, 2023
Merged

Move side-effects out of common.cmake and into CMakeLists.txt #5287

merged 5 commits into from
May 23, 2023

Conversation

achamayou
Copy link
Member

Closes #2953

@achamayou achamayou requested a review from a team May 19, 2023 14:30
@ghost
Copy link

ghost commented May 19, 2023 •
edited by ghost
Loading

helpers_only_in_common_cmake_2@70742 aka 20230523.8 vs main ewma over 20 builds from 70426 to 70727

Click to see table

main

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
70426 20230517.1 0.81237 45808.8 47715.8 12588.6 12853.1 20362.8 1.88908e+07 4455.17 20507.9 1.25993e+07 6722.38 1.67936e+07 3753.59 6564.1 6.30784e+06 3306.29 1729.35 1.05021e+07 45997.3 1507.22 1.05021e+07 1404.19 1.05021e+07 836591 1.17793e+06 8.15316e+06 3.08188e+07
70446 20230517.11 0.808969 45830.1 44462.2 12412.1 12991.1 20276.3 1.88908e+07 4435.62 20491.8 1.25993e+07 6688.21 1.67936e+07 3758.95 6553.9 6.30784e+06 3263.36 1736.1 1.05021e+07 42557.7 1493.11 1.05021e+07 1405.17 1.05021e+07 837823 1.17591e+06 8.16587e+06 3.14409e+07
70455 20230517.14 0.820054 45840.3 48262.3 12592.4 13017.5 20150.6 1.88908e+07 4406.23 20383.9 1.25993e+07 6345.12 1.67936e+07 3844.57 6552.2 6.30784e+06 3375.8 1709.45 1.05021e+07 48706.8 1507.48 1.05021e+07 1401.45 1.05021e+07 833673 1.18118e+06 8.15511e+06 3.10717e+07
70482 20230518.1 0.782545 45917.5 47944.8 12557.3 12755.6 20293.7 1.88908e+07 4438.61 20493 1.25993e+07 6376.04 1.67936e+07 3714.67 6549.8 6.30784e+06 3264.91 1733.99 1.05021e+07 43812.8 1505.44 1.05021e+07 1409.96 1.05021e+07 828045 1.17621e+06 8.15468e+06 3.09487e+07
70501 20230518.9 0.760928 45534.8 48083.4 12397 13013.7 20409.1 1.88908e+07 4456.78 20456.5 1.25993e+07 6729.09 1.67936e+07 3747.93 6574.6 6.30784e+06 3266.19 1713.67 1.05021e+07 50895.9 1508.72 1.05021e+07 1404.86 1.05021e+07 828628 1.18065e+06 8.15238e+06 3.06849e+07
70523 20230518.15 0.810363 45927 48404.1 12549 13164.5 20338.9 1.88908e+07 4454.85 20460.4 1.25993e+07 6403.9 1.67936e+07 3711.14 6556.9 6.30784e+06 3248.07 1729.7 1.05021e+07 48937.9 1508.06 1.05021e+07 1420.8 1.05021e+07 822475 1.17642e+06 8.15407e+06 3.08987e+07
70550 20230518.25 0.796913 45688.4 48136.9 12530.4 12899.8 20117.7 1.88908e+07 4411.8 20437.4 1.25993e+07 6355.43 1.67936e+07 3420.74 6555.7 6.30784e+06 3245.34 1712.95 1.05021e+07 50905.7 1424.1 1.05021e+07 1408.73 1.05021e+07 820462 1.18188e+06 8.17157e+06 3.08904e+07
70563 20230518.28 0.812575 45820.9 48650 12377.8 13067.5 20196.3 1.88908e+07 4430.28 20351.4 1.25993e+07 6733.62 1.67936e+07 3557.24 6545.4 6.30784e+06 3241.85 1712.56 1.05021e+07 48895.6 1424.67 1.05021e+07 1404.81 1.05021e+07 829922 1.18287e+06 8.17415e+06 3.08127e+07
70569 20230519.2 0.766523 45834.8 48591.3 12629.3 13189.5 20310.2 1.88908e+07 4464.15 20413.2 1.25993e+07 6381.15 1.67936e+07 3493.67 6557.9 6.30784e+06 3263.95 1734.35 1.05021e+07 45874.4 1420.15 1.05021e+07 1420.55 1.05021e+07 824598 1.18101e+06 8.02451e+06 3.14294e+07
70577 20230519.6 0.787617 47890.3 48853.4 12612.7 13378.8 20215.9 1.88908e+07 4419.46 20424.4 1.25993e+07 6727.28 1.67936e+07 3540.16 6555.7 6.30784e+06 3253.95 1731.41 1.05021e+07 49376.6 1422.39 1.05021e+07 1406.75 1.05021e+07 822570 1.18101e+06 8.14995e+06 3.08438e+07
70589 20230519.9 0.785013 45689.1 48452.2 12449 13186.2 20173 1.88908e+07 4417.9 20404.8 1.25993e+07 6710.23 1.67936e+07 3568.74 6510.5 6.30784e+06 3277.78 1730.48 1.05021e+07 51265.9 1423.21 1.05021e+07 1407.63 1.05021e+07 834496 1.17305e+06 8.17186e+06 3.11815e+07
70601 20230519.12 0.807722 45586.9 48781.7 12583.6 12859.3 20289.1 1.88908e+07 4404.27 20646.1 1.25993e+07 6706.5 1.67936e+07 3472.97 6515.7 6.30784e+06 3269.42 1709.88 1.05021e+07 46389.7 1419.84 1.05021e+07 1420.01 1.05021e+07 833122 1.17447e+06 8.153e+06 3.08462e+07
70618 20230519.17 0.809011 47900.4 49820.9 12618 13165.2 20227.4 1.88908e+07 4432.57 20426.5 1.25993e+07 6367.02 1.67936e+07 3565.38 6468.8 6.30784e+06 3347.63 1703.92 1.05021e+07 49195.6 1418.22 1.05021e+07 1400.81 1.05021e+07 824337 1.17968e+06 8.0979e+06 3.07975e+07
70632 20230519.21 0.794521 47979.7 49379.6 12490.7 12996 20292.4 1.88908e+07 4455.53 20463.5 1.25993e+07 6716.04 1.67936e+07 3473.44 6505.5 6.30784e+06 3267.77 1708.14 1.05021e+07 46172.2 1410.43 1.05021e+07 1402.34 1.05021e+07 837015 1.17203e+06 8.13564e+06 3.18695e+07
70639 20230519.23 0.782483 47760.6 49472.6 12359.8 13137 20252.5 1.88908e+07 4431.2 20448.1 1.25993e+07 6721.85 1.67936e+07 3432.79 6520.7 6.30784e+06 3352.76 1708.72 1.05021e+07 44709.1 1419.75 1.05021e+07 1402.05 1.05021e+07 832054 1.17507e+06 8.15423e+06 3.07998e+07
70675 20230522.1 0.807478 45858.8 48941.9 12485.9 12792.3 20278.6 1.88908e+07 4431.39 20531.6 1.25993e+07 6764.2 1.67936e+07 3479.31 6545 6.30784e+06 3260.7 1713.83 1.05021e+07 45960.4 1425.76 1.05021e+07 1402.51 1.05021e+07 829624 1.18345e+06 8.13745e+06 3.07457e+07
70682 20230522.5 0.800285 43803.2 46287.5 11405.2 12701.9 20305.5 1.88908e+07 4247.21 20509.8 1.25993e+07 6769.17 1.67936e+07 3327.07 6557.5 6.30784e+06 3125.33 1710.79 1.05021e+07 49394.4 1423.41 1.05021e+07 1408.78 1.05021e+07 829768 1.17658e+06 8.14667e+06 3.12405e+07
70707 20230522.15 0.794519 47954.8 49325.3 12479.8 13010.8 20328.1 1.88908e+07 4450.34 20476.1 1.25993e+07 6676.08 1.88908e+07 3482.17 6502.6 6.30784e+06 3264.51 1712.94 1.05021e+07 46050.4 1420.42 1.05021e+07 1411.15 1.05021e+07 828546 1.18055e+06 8.1295e+06 3.07697e+07
70718 20230522.18 0.800798 45817.4 47497.4 12569.7 12987.4 20250.8 1.88908e+07 4457.46 20472.4 1.25993e+07 6721.66 1.88908e+07 3582.61 6561.6 6.30784e+06 3367.13 1714.52 1.05021e+07 48088.5 1418.17 1.05021e+07 1408.29 1.05021e+07 834967 1.1861e+06 8.13247e+06 3.07951e+07
70727 20230523.1 0.796101 45451.1 47770.4 12509.7 13078.9 20381.1 1.88908e+07 4373.86 20613.8 1.25993e+07 6728.23 1.67936e+07 3578.48 6555.7 6.30784e+06 3262.66 1731.53 1.05021e+07 51249.9 1422.4 1.05021e+07 1418.29 1.05021e+07 804453 1.16904e+06 8.15264e+06 3.09062e+07

helpers_only_in_common_cmake_2

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
70645 20230519.24 0.774188 47675.5 48867.7 12551.9 13011.9 20216.5 1.88908e+07 4414.41 20553 1.25993e+07 3552.49 6732.71 1.67936e+07 6502.3 6.30784e+06 3241.96 1709.05 1.05021e+07 48539 1414.45 1.05021e+07 1399.95 1.05021e+07 828814 1.17419e+06 8.14667e+06 3.07706e+07
70688 20230522.6 0.792026 45731.6 49070.6 12418 12813.8 20335.1 1.88908e+07 4435.75 20608.4 1.25993e+07 3550.04 6712.25 1.67936e+07 6563.8 6.30784e+06 3262.67 1709.67 1.05021e+07 51114.3 1417.25 1.05021e+07 1407.66 1.05021e+07 833342 1.17951e+06 8.15592e+06 3.12657e+07
70733 20230523.5 0.785867 45638 47374.3 12601.8 12972.2 20312.7 1.88908e+07 4463.39 20496.2 1.25993e+07 3487.04 6710.77 1.67936e+07 6613.8 6.30784e+06 3263 1732.52 1.05021e+07 48676.6 1421.2 1.05021e+07 1418.37 1.05021e+07 838458 1.17537e+06 8.14214e+06 3.04006e+07
70742 20230523.8 0.800516 45820 47659.7 12540.2 12997.7 20285.9 1.88908e+07 4440.9 20442.9 1.25993e+07 3568.12 6354.52 1.67936e+07 6502.4 6.30784e+06 3274.21 1711.37 1.05021e+07 45842 1420.9 1.05021e+07 1406.27 1.05021e+07 833059 1.17503e+06 8.13651e+06 3.08638e+07

images

eddyashton
eddyashton approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@eddyashton eddyashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you poke the daily canary, and maybe threading too, to make sure we're covering a variety of build configurations?

@achamayou achamayou merged commit b0b9b0c into microsoft:main May 23, 2023
eddyashton pushed a commit to eddyashton/CCF that referenced this pull request May 31, 2023
@achamayou @eddyashton
Move side-effects out of common.cmake and into CMakeLists.txt (micros…
cc25818 
…oft#5287)
@achamayou achamayou added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Jul 7, 2023
@ghost ghost mentioned this pull request Jul 7, 2023
Merged
ghost pushed a commit that referenced this pull request Jul 7, 2023
@achamayou
Move side-effects out of common.cmake and into CMakeLists.txt (#5287)
b11df2c 
(cherry picked from commit b0b9b0c)
@ghost ghost added the backported This PR was successfully backported to LTS branch label Jul 7, 2023
achamayou added a commit that referenced this pull request Jul 7, 2023
@achamayou
[release/4.x] Cherry pick: Move side-effects out of common.cmake and …
450ed9a 
…into CMakeLists.txt (#5287) (#5423)

Co-authored-by: Amaury Chamayou <amchamay@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaffre jumaffre jumaffre approved these changes

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor common.cmake to contain only helper-type code
3 participants
@achamayou @eddyashton @jumaffre