Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger_json_test #5426

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix logger_json_test #5426

merged 1 commit into from
Jul 10, 2023

Conversation

eddyashton
Copy link
Member

Fixes #5420, broken since #5375.

@eddyashton eddyashton added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Jul 10, 2023
@eddyashton eddyashton requested a review from a team July 10, 2023 10:54
@ghost
Copy link

ghost commented Jul 10, 2023

logger_json_test_fix@72708 aka 20230710.5 vs main ewma over 20 builds from 72403 to 72698

Click to see table

main

build_id build_number Commit latency factor pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem
72403 20230627.18 0.826649 57173.4 45807.8 47641.5 56010.8 12287.1 12818.2 4457.29 3585.18 3377.04 48551.5 19964 1.88908e+07 20263 1.25993e+07 22603 1.25993e+07 6675.78 1.67936e+07 6522 6.30784e+06 1745.29 1.05021e+07 1437.24 1.05021e+07 1432.06 1.05021e+07 835700 1.17615e+06 8.17297e+06 3.07166e+07 35745.4 2.51822e+07
72414 20230627.22 0.782261 58014.7 45570.4 47412.7 55507.9 12445.7 13048.7 4465.08 3567.14 3392.01 48397.2 19974.5 1.88908e+07 20296 1.05021e+07 22888.8 1.25993e+07 6707.83 1.67936e+07 6508 6.30784e+06 1762.63 1.05021e+07 1440.21 1.05021e+07 1426.65 1.05021e+07 827058 1.18005e+06 8.17493e+06 3.06582e+07 35567.1 2.30851e+07
72421 20230628.1 0.761085 63085.1 45793.6 47897.3 55456.6 12400.6 12990.9 4423.61 3588.42 3303.7 43309.5 19985.9 1.88908e+07 20171.1 1.25993e+07 22860.3 1.25993e+07 6344.03 1.67936e+07 6568.5 6.30784e+06 1751.62 1.05021e+07 1440.1 1.05021e+07 1429.72 1.05021e+07 834665 1.17866e+06 8.15209e+06 3.07646e+07 35513.1 2.30851e+07
72436 20230628.7 0.812082 60489.4 45756.4 47828.3 55452.4 12566.5 12921.1 4468.19 3464.73 3378.16 45121.5 19941.7 1.88908e+07 20191.5 1.25993e+07 22946.5 1.25993e+07 6699.02 1.67936e+07 6519.4 6.30784e+06 1762.47 1.05021e+07 1440.87 1.05021e+07 1431.31 1.05021e+07 832343 1.18084e+06 8.17477e+06 3.10873e+07 35354.6 2.51822e+07
72446 20230629.1 0.79726 65902.1 45706.1 47595.5 55593.5 12499.6 12672.7 4433.8 3552.85 3364.21 47859.6 19984.4 1.88908e+07 20130.2 1.25993e+07 22794.7 1.25993e+07 6313.16 1.67936e+07 6476.1 6.30784e+06 1743.35 1.05021e+07 1443.8 1.05021e+07 1431.7 1.05021e+07 835992 1.17401e+06 8.13615e+06 3.2025e+07 35235.7 2.51822e+07
72457 20230629.7 0.836172 56033.3 45903.5 47464.2 55539.9 12526.4 12919.9 4502.49 3579.1 3257.95 50359.7 19949.1 1.88908e+07 20124.7 1.05021e+07 22775.9 1.25993e+07 6342.9 1.67936e+07 6510.9 6.30784e+06 1746.41 1.05021e+07 1438.67 1.05021e+07 1426.47 1.05021e+07 836001 1.18336e+06 8.17415e+06 3.0736e+07 35999.6 2.51822e+07
72470 20230629.11 0.820991 64353.8 45669.2 47537.5 55455.4 12501.6 12979.3 4437.55 3596.63 3385.29 48706.1 19845.1 1.88908e+07 20161.5 1.25993e+07 22899.9 1.25993e+07 6689.48 1.67936e+07 6470.9 6.30784e+06 1745.17 1.05021e+07 1439.56 1.05021e+07 1426.72 1.05021e+07 823851 1.18212e+06 8.13541e+06 3.15276e+07 35582.9 2.51822e+07
72480 20230630.1 0.814747 55751.5 45723.9 47528.8 55293.2 12412.7 12703.4 4467.85 3593.74 3383.35 42801.9 19851.3 1.88908e+07 20203.8 1.25993e+07 22846.9 1.25993e+07 6322.54 1.67936e+07 6510.5 6.30784e+06 1737.33 1.05021e+07 1436.68 1.05021e+07 1428.85 1.05021e+07 835136 1.17788e+06 8.12457e+06 3.08727e+07 35599.4 2.51822e+07
72492 20230703.1 0.803381 65525.6 45839.6 47420.8 52483.2 12422.9 13003.4 4475.51 3516.86 3256.88 48601.7 19929 1.88908e+07 20125.3 1.25993e+07 22911.1 1.25993e+07 6700.23 1.67936e+07 6462.7 6.30784e+06 1748.42 1.05021e+07 1447.19 1.05021e+07 1433.01 1.05021e+07 838528 1.18092e+06 8.13619e+06 3.0689e+07 35541.5 2.51822e+07
72511 20230704.1 0.788467 66684.1 45730.3 47716.5 55439.3 12517.3 12827.1 4421.76 3576.87 3215.16 48681.3 20003 1.88908e+07 20249 1.25993e+07 23002.4 1.25993e+07 6751.03 1.67936e+07 6565.7 6.30784e+06 1766.68 1.05021e+07 1440.13 1.05021e+07 1434.55 1.05021e+07 837219 1.1837e+06 8.15452e+06 3.09412e+07 35778.7 2.51822e+07
72518 20230704.5 0.810358 54985.1 43590.3 46999.3 54920.3 12293.2 12863.1 4484.94 3512.36 3296.63 43890.3 19990.7 1.88908e+07 20224 1.25993e+07 22996 1.25993e+07 6382.67 1.67936e+07 6515 6.30784e+06 1745.43 1.05021e+07 1441.45 1.05021e+07 1433.36 1.05021e+07 831120 1.17226e+06 8.15537e+06 3.0718e+07 35577 2.51822e+07
72535 20230704.11 0.809873 55285.3 45757.3 48362.4 55737.5 12575.9 13184.8 4460.99 3571.1 3230.93 51096.9 19722.5 1.88908e+07 20094.7 1.25993e+07 22844.3 1.25993e+07 6345.98 1.67936e+07 6424.8 6.30784e+06 1735.62 1.05021e+07 1439.94 1.05021e+07 1427.56 1.05021e+07 834507 1.17981e+06 8.15416e+06 3.07933e+07 35866.1 2.51822e+07
72542 20230704.13 0.795832 75747.7 45881.4 47876 55818.5 12428.3 13009 4478.04 3601.03 3416.26 48649.2 19825.5 1.88908e+07 20265.3 1.05021e+07 23013.5 1.25993e+07 6723.21 1.67936e+07 6469.8 6.30784e+06 1744.77 1.05021e+07 1441.13 1.05021e+07 1431.19 1.05021e+07 842097 1.17452e+06 8.17405e+06 3.08429e+07 35761.7 2.30851e+07
72563 20230705.1 0.837403 63968.2 45762.3 48395.9 55921.1 12433 12883.3 4441 3585.04 3387.97 48254.6 19978.7 1.88908e+07 20194.9 1.25993e+07 22974.2 1.25993e+07 6680.38 1.67936e+07 6525 6.30784e+06 1742.76 1.05021e+07 1443.46 1.05021e+07 1433.91 1.05021e+07 830201 1.18341e+06 8.17457e+06 3.08369e+07 36005.7 2.51822e+07
72581 20230706.1 0.802693 57112.4 45757.9 47804.3 55664.2 12402.1 13046.5 4507.57 3493.88 3301.02 48268.1 20043.9 1.88908e+07 20253 1.05021e+07 23064.9 1.25993e+07 6352.51 1.67936e+07 6520.5 6.30784e+06 1747.78 1.05021e+07 1442.92 1.05021e+07 1429.37 1.05021e+07 836151 1.18164e+06 8.15267e+06 3.08392e+07 35948.3 2.51822e+07
72595 20230706.7 0.812809 54274.5 45751.5 48020.4 55730.9 12373.3 13088.3 4502.69 3617.8 3329.05 43367.1 19948.3 1.88908e+07 20174.7 1.25993e+07 22892.5 1.25993e+07 6347.59 1.67936e+07 6513.6 6.30784e+06 1745.91 1.05021e+07 1444.13 1.05021e+07 1431.13 1.05021e+07 832506 1.1805e+06 8.15449e+06 3.08044e+07 35566.7 2.51822e+07
72636 20230706.20 0.812909 55356.9 45879.2 47828.4 55187 12330.4 13116.5 4491.17 3607.09 3294.02 44092.4 19788.9 1.88908e+07 19954.7 1.25993e+07 22943 1.25993e+07 6353.47 1.67936e+07 6433.5 6.30784e+06 1746.38 1.05021e+07 1437.03 1.05021e+07 1414.03 1.05021e+07 836826 1.18144e+06 8.15641e+06 3.18349e+07 35630.6 2.51822e+07
72651 20230707.1 0.781317 63504.1 45641.9 47893.2 55811.3 12511.9 12907.1 4454.64 3579.39 3411.35 48041.1 19916.8 1.88908e+07 20104.6 1.25993e+07 22980.2 1.25993e+07 6684.11 1.67936e+07 6569.2 6.30784e+06 1763.19 1.05021e+07 1441.46 1.05021e+07 1433.71 1.05021e+07 839165 1.18029e+06 8.15481e+06 3.10807e+07 35620.8 2.51822e+07
72669 20230707.8 0.779087 59409.2 45864.2 47558.3 55289.6 12416.1 12959.3 4414.4 3556.35 3292.52 50504.8 20012.1 1.88908e+07 20192.6 1.25993e+07 22819.4 1.25993e+07 6712.83 1.67936e+07 6561.9 6.30784e+06 1746.48 1.05021e+07 1439.36 1.05021e+07 1431.33 1.05021e+07 837854 1.18229e+06 8.15202e+06 3.08183e+07 35433.2 2.51822e+07
72698 20230710.1 0.795285 72077.9 45816.2 47740.2 54544.5 12495.6 13014.4 4416.71 3454.62 3274.47 48588.3 20048.2 1.88908e+07 20215.7 1.25993e+07 22861.5 1.25993e+07 6338.57 1.67936e+07 6618.3 6.30784e+06 1768.14 1.05021e+07 1442.9 1.05021e+07 1434.09 1.05021e+07 826908 1.17253e+06 8.13493e+06 3.00412e+07 35727.2 2.51822e+07

logger_json_test_fix

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem hist_sgx_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
72708 20230710.5 0.792379 45753.3 47609.1 49266.9 12453.6 12732.5 35451.3 2.51822e+07 65600.9 4487.32 3537.6 20046.3 1.88908e+07 3286.58 20191.2 1.25993e+07 22903.1 1.25993e+07 6721.85 1.67936e+07 6556.3 6.30784e+06 48835.7 1765.06 1.05021e+07 1448.04 1.05021e+07 1433.61 1.05021e+07 833177 1.18458e+06 8.15141e+06 3.06619e+07

images

@eddyashton eddyashton merged commit 8d0ad3f into microsoft:main Jul 10, 2023
@ghost ghost mentioned this pull request Jul 10, 2023
Merged
ghost pushed a commit that referenced this pull request Jul 10, 2023
@eddyashton
Fix logger_json_test (#5426)
6e58f12 
(cherry picked from commit 8d0ad3f)
@ghost ghost added the backported This PR was successfully backported to LTS branch label Jul 10, 2023
eddyashton pushed a commit that referenced this pull request Jul 12, 2023
[release/4.x] Cherry pick: Fix logger_json_test (#5426) (#5427)
3f1e751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaffre jumaffre jumaffre approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logger_json_test failure
2 participants
@eddyashton @jumaffre